Skip to content

Commit db617dd

Browse files
Support dill 0.3.6 (#5166)
* Remove fix on dill >= 0.3.6 * Unpin dill * Fix dill save_function for dill 0.3.6 * Fix dill save_code for dill 0.3.6 * Pin dill<0.3.7 to support it explicitly in their next release * Fix CI to test latest dill * Fix style * Fix dill _save_regex for dill 0.3.6 * Fix _save_regex * Uninstall apache-beam for CI latest dependencies * Fix uninstall of apache-beam * Remove raising error when pickling logger * Use pickable MagicMock when patching * Fix style
1 parent a2576b8 commit db617dd

File tree

4 files changed

+380
-80
lines changed

4 files changed

+380
-80
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,12 @@ jobs:
6464
pip install -r additional-tests-requirements.txt --no-deps
6565
- name: Install dependencies (latest versions)
6666
if: ${{ matrix.deps_versions == 'latest' }}
67-
run: pip install --upgrade pyarrow huggingface-hub
68-
- name: Install depencencies (minimum versions)
67+
run: |
68+
pip uninstall -y apache-beam
69+
pip install --upgrade pyarrow huggingface-hub dill
70+
- name: Install dependencies (minimum versions)
6971
if: ${{ matrix.deps_versions != 'latest' }}
70-
run: pip install pyarrow==6.0.1 huggingface-hub==0.2.0 transformers
72+
run: pip install pyarrow==6.0.1 huggingface-hub==0.2.0 transformers dill==0.3.1.1
7173
- name: Test with pytest
7274
run: |
7375
python -m pytest -rfExX -m ${{ matrix.test }} -n 2 --dist loadfile -sv ./tests/

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
# Minimum 6.0.0 to support wrap_array which is needed for ArrayND features
7171
"pyarrow>=6.0.0",
7272
# For smart caching dataset processing
73-
"dill<0.3.6", # tmp pin until 0.3.6 release: see https://github.com/huggingface/datasets/pull/4397
73+
"dill<0.3.7", # tmp pin until next 0.3.7 release: see https://github.com/huggingface/datasets/pull/5166
7474
# For performance gains with apache arrow
7575
"pandas",
7676
# for downloading datasets over HTTPS

0 commit comments

Comments
 (0)