Skip to content

Commit 5747ad6

Browse files
committed
Fix issue where pandas<1.4.0 doesn't return the number of rows
1 parent f76b87c commit 5747ad6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/datasets/io/sql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def _write(self, conn: Connection, **to_sql_kwargs) -> int:
114114
df = self._batch_sql(offset)
115115
written += df.to_sql(
116116
self.table_name, conn, **to_sql_kwargs, if_exists="replace" if offset == 0 else "append"
117-
)
117+
) or len(df)
118118

119119
else:
120120
num_rows, batch_size = len(self.dataset), self.batch_size
@@ -133,6 +133,6 @@ def _write(self, conn: Connection, **to_sql_kwargs) -> int:
133133
):
134134
written += df.to_sql(
135135
self.table_name, conn, **to_sql_kwargs, if_exists="replace" if idx == 0 else "append"
136-
)
136+
) or len(df)
137137

138138
return written

0 commit comments

Comments
 (0)