Skip to content

Commit 30000fb

Browse files
Fix CI test_convert_to_parquet (#7078)
* Unmark test_convert_to_parquet as xfail * Fix test_convert_to_parquet by patching HfApi.preupload_lfs_files
1 parent 45c5b3d commit 30000fb

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tests/test_hub.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ def test_dataset_url(repo_id, filename, revision):
4545
assert url == f"https://huggingface.co/datasets/{repo_id}/resolve/{revision or 'main'}/{quote(filename)}"
4646

4747

48-
# Temporarily mark this test as expected to fail: GH-7073
49-
@pytest.mark.xfail
5048
def test_convert_to_parquet(temporary_repo, hf_api, hf_token, ci_hub_config, ci_hfh_hf_hub_url):
5149
with temporary_repo() as repo_id:
5250
hf_api.create_repo(repo_id, token=hf_token, repo_type="dataset")
@@ -64,7 +62,8 @@ def test_convert_to_parquet(temporary_repo, hf_api, hf_token, ci_hub_config, ci_
6462
with patch.object(datasets.hub.HfApi, "create_commit", return_value=commit_info) as mock_create_commit:
6563
with patch.object(datasets.hub.HfApi, "create_branch") as mock_create_branch:
6664
with patch.object(datasets.hub.HfApi, "list_repo_tree", return_value=[]): # not needed
67-
_ = convert_to_parquet(repo_id, token=hf_token, trust_remote_code=True)
65+
with patch.object(datasets.hub.HfApi, "preupload_lfs_files", return_value=None): # not needed
66+
_ = convert_to_parquet(repo_id, token=hf_token, trust_remote_code=True)
6867
# mock_create_branch
6968
assert mock_create_branch.called
7069
assert mock_create_branch.call_count == 2

0 commit comments

Comments
 (0)