Skip to content

Commit 14d9afb

Browse files
Fix missing info when loading some datasets from Parquet export (#6635)
* set default config when single config parquet export * fix tests * fix test * Update src/datasets/utils/metadata.py Co-authored-by: Albert Villanova del Moral <[email protected]> --------- Co-authored-by: Albert Villanova del Moral <[email protected]>
1 parent ba3cfad commit 14d9afb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/datasets/utils/metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ def to_dataset_card_data(self, dataset_card_data: DatasetCardData) -> None:
253253
def get_default_config_name(self) -> Optional[str]:
254254
default_config_name = None
255255
for config_name, metadata_config in self.items():
256-
if config_name == "default" or metadata_config.get("default"):
256+
if len(self) == 1 or config_name == "default" or metadata_config.get("default"):
257257
if default_config_name is None:
258258
default_config_name = config_name
259259
else:

tests/test_load.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ def test_LocalDatasetModuleFactoryWithoutScript_with_single_config_in_metadata(s
523523
assert module_builder_configs[0].drop_labels is True # parameter is passed from metadata
524524

525525
# config named "default" is automatically considered to be a default config
526-
assert module_factory_result.builder_configs_parameters.default_config_name is None
526+
assert module_factory_result.builder_configs_parameters.default_config_name == "custom"
527527

528528
# we don't pass config params to builder in builder_kwargs, they are stored in builder_configs directly
529529
assert "drop_labels" not in module_factory_result.builder_kwargs
@@ -695,7 +695,7 @@ def test_HubDatasetModuleFactoryWithoutScript_with_one_default_config_in_metadat
695695
assert module_builder_configs[0].drop_labels is True # parameter is passed from metadata
696696

697697
# config named "default" is automatically considered to be a default config
698-
assert module_factory_result.builder_configs_parameters.default_config_name is None
698+
assert module_factory_result.builder_configs_parameters.default_config_name == "custom"
699699

700700
# we don't pass config params to builder in builder_kwargs, they are stored in builder_configs directly
701701
assert "drop_labels" not in module_factory_result.builder_kwargs

tests/test_metadata_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def test_from_yaml_string(self):
224224
@pytest.mark.parametrize(
225225
"readme_content, expected_metadata_configs_dict, expected_default_config_name",
226226
[
227-
(README_METADATA_SINGLE_CONFIG, EXPECTED_METADATA_SINGLE_CONFIG, None),
227+
(README_METADATA_SINGLE_CONFIG, EXPECTED_METADATA_SINGLE_CONFIG, "custom"),
228228
(README_METADATA_TWO_CONFIGS_WITH_DEFAULT_FLAG, EXPECTED_METADATA_TWO_CONFIGS_DEFAULT_FLAG, "v2"),
229229
(README_METADATA_TWO_CONFIGS_WITH_DEFAULT_NAME, EXPECTED_METADATA_TWO_CONFIGS_DEFAULT_NAME, "default"),
230230
],

0 commit comments

Comments
 (0)