Use "h" property as height when drawing Graph meter

This is a code quality change that avoids dependency on the hard-coded
GRAPH_HEIGHT in GraphMeterMode_draw().

This doesn't enable variable graph heights per meter, but it makes room
for implementing such feature.

Signed-off-by: Kang-Che Sung <[email protected]>

Author: Explorer09

Meter.c

@@ -30,7 +30,7 @@ in the source distribution for its full text.
 #define UINT32_WIDTH 32
 #endif
 
-#define GRAPH_HEIGHT 4 /* Unit: rows (lines) */
+#define DEFAULT_GRAPH_HEIGHT 4 /* Unit: rows (lines) */
 
 typedef struct MeterMode_ {
    Meter_Draw draw;
@@ -247,6 +247,8 @@ static void GraphMeterMode_draw(Meter* this, int x, int y, int w) {
    w -= captionLen;
 
    // Prepare parameters for drawing
+   assert(this->h >= 1);
+   int h = this->h;
    uint8_t maxItems = Meter_maxItems(this);
    bool isPercentChart = Meter_isPercentChart(this);
    GraphData* data = &this->drawData;
@@ -288,7 +290,7 @@ static void GraphMeterMode_draw(Meter* this, int x, int y, int w) {
       goto end;
    }
 
-   bool needsScaleDisplay = maxItems > 0 && GRAPH_HEIGHT >= 2;
+   bool needsScaleDisplay = maxItems > 0 && h >= 2;
    if (needsScaleDisplay) {
       move(y + 1, x); // Cursor position for printing the scale
    }
@@ -342,14 +344,14 @@ static void GraphMeterMode_draw(Meter* this, int x, int y, int w) {
 
    // Draw the actual graph
    for (int col = 0; i < nValues - 1; i += 2, col++) {
-      int pix = GraphMeterMode_pixPerRow * GRAPH_HEIGHT;
+      int pix = GraphMeterMode_pixPerRow * h;
       int v1 = (int) lround(CLAMP(data->values[i] / total * pix, 1.0, pix));
       int v2 = (int) lround(CLAMP(data->values[i + 1] / total * pix, 1.0, pix));
 
       int colorIdx = GRAPH_1;
-      for (int line = 0; line < GRAPH_HEIGHT; line++) {
-         int line1 = CLAMP(v1 - (GraphMeterMode_pixPerRow * (GRAPH_HEIGHT - 1 - line)), 0, GraphMeterMode_pixPerRow);
-         int line2 = CLAMP(v2 - (GraphMeterMode_pixPerRow * (GRAPH_HEIGHT - 1 - line)), 0, GraphMeterMode_pixPerRow);
+      for (int line = 0; line < h; line++) {
+         int line1 = CLAMP(v1 - (GraphMeterMode_pixPerRow * (h - 1 - line)), 0, GraphMeterMode_pixPerRow);
+         int line2 = CLAMP(v2 - (GraphMeterMode_pixPerRow * (h - 1 - line)), 0, GraphMeterMode_pixPerRow);
 
          attrset(CRT_colors[colorIdx]);
          mvaddstr(y + line, x + col, GraphMeterMode_dots[line1 * (GraphMeterMode_pixPerRow + 1) + line2]);
@@ -463,7 +465,7 @@ static const MeterMode Meter_modes[] = {
    },
    [GRAPH_METERMODE] = {
       .uiName = "Graph",
-      .h = GRAPH_HEIGHT,
+      .h = DEFAULT_GRAPH_HEIGHT,
       .draw = GraphMeterMode_draw,
    },
    [LED_METERMODE] = {