Replacement textures: Don't spend frame time waiting for a texture to be finished #20520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be finished It's better to finish rendering the frame and have the texture ready for the next one, without wasting CPU. However, if the user set their texture load speed to "Instant", that means they never want to see any original textures. So in that case, we do still wait. Fixes #20519
hrydgard
added a commit
that referenced
this pull request
Jun 15, 2025
Replacement textures: Don't spend frame time waiting for a texture to be finished
hrydgard
added a commit
that referenced
this pull request
Jun 15, 2025
Replacement textures: Don't spend frame time waiting for a texture to be finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some old logic that I don't think actually makes sense.
It's better to finish rendering the frame and have the texture ready for the next one, without wasting CPU. Even if we have a set frametime budget, it's too costly to waste it waiting for a single texture.
However, if the user set their texture load speed to "Instant", that means they never want to see any original textures ever. So in that case, we do still wait.
Fixes #20519