Skip to content

Screenshot performance improvement #20137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2025
Merged

Screenshot performance improvement #20137

merged 5 commits into from
Mar 20, 2025

Conversation

@hrydgard
Copy link
Owner

@hrydgard hrydgard commented Mar 20, 2025

Two changes:

  • Now runs PNG/JPG encoding on separate threads in the background
  • If there are many files, on slow file systems (like Android scoped storage) the way we checked for a free filename was atrociously slow. Switched to just getting the full file listing, which is pretty quick, and then scanning that.

Hopefully fixes #20134 . At least, for me, it seems really fast now.

@hrydgard hrydgard added this to the v1.19.0 milestone Mar 20, 2025
@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Mar 20, 2025
@hrydgard hrydgard mentioned this pull request Mar 20, 2025
Closed
5 tasks
@hrydgard hrydgard force-pushed the screenshot-speedup branch from a856abe to 6a71cbe Compare March 20, 2025 19:49
@hrydgard hrydgard merged commit a68e429 into master Mar 20, 2025
19 checks passed
@hrydgard hrydgard deleted the screenshot-speedup branch March 20, 2025 20:46
@Unknowncat1991 Unknowncat1991 mentioned this pull request Mar 21, 2025
Closed
5 tasks
@Unknowncat1991
Copy link

Unknowncat1991 commented Mar 21, 2025

This produce crash if you create save state or reporting feedback see ~ #20139

@NABN00B NABN00B mentioned this pull request May 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

User Interface PPSSPP's own user interface / UX

Projects

None yet

Milestone

v1.19.0

Development

Successfully merging this pull request may close these issues.

Screenshots freeze the emulator for more than a few seconds

3 participants

@hrydgard @Unknowncat1991