File tree Expand file tree Collapse file tree 2 files changed +5
-1
lines changed Expand file tree Collapse file tree 2 files changed +5
-1
lines changed Original file line number Diff line number Diff line change @@ -175,7 +175,7 @@ const readers: { [type: string]: Reader } = {
175175 } ,
176176
177177 boolean ( value : string ) : boolean {
178- return ! ( value == "0" || value == "false" )
178+ return ! ( value == "0" || String ( value ) . toLowerCase ( ) == "false" )
179179 } ,
180180
181181 number ( value : string ) : number {
Original file line number Diff line number Diff line change @@ -66,6 +66,10 @@ export default class ValueTests extends ControllerTestCase(ValueController) {
6666 this . controller . shadowedBooleanValue = 1 as any
6767 this . assert . deepEqual ( this . controller . shadowedBooleanValue , true )
6868 this . assert . deepEqual ( this . get ( "shadowed-boolean-value" ) , "1" )
69+
70+ this . controller . shadowedBooleanValue = "False" as any
71+ this . assert . deepEqual ( this . controller . shadowedBooleanValue , false )
72+ this . assert . deepEqual ( this . get ( "shadowed-boolean-value" ) , "False" )
6973 }
7074
7175 "test array values" ( ) {
You can’t perform that action at this time.
0 commit comments