feat: 570 kotlin support

[Alex-ley-scrub]

/claim #570
fixes #570

todo:

• Add the language as a supported language in the GritQL grammar
• Find a tree sitter grammar for the language and add it as a submodule under resources/language-submodules.
• Add a simple parse test in crates/core/src/test.rs to ensure that the grammar is working.
• Copy the grammar file into resources/metavariable-grammars. This alternative grammar is used for parsing snippets in GritQL.
• add resources/add_language.py and run it with python resources/add_language.py --lang kotlin
  • add "kotlin" to edit_grammars.mjs
  • run node ./resources/edit_grammars.mjs kotlin
• Patch the metavariable grammar to include $.grit_metavariable anywhere we want to substitute a metavariable
• Add a new language implementation in crates/core/languages/src. This involves implementing the Language trait and adding a new Language enum variant and adding it to all match statements
  • crates/core/languages/src/kotlin.rs
  • cargo test --package marzano-language --lib -- kotlin::tests --show-output
• Add snippet_context_strings to provide context for snippets to match in.
• Add kotlin to the PatternsDirectory struct in crates/gritmodule/src/patterns_directory.rs add it to all match statements
• Add Kotlin to all match statements in crates/lsp/src/language.rs
• add KOTLIN_LANGUAGE as a static in crates/wasm-bindings/src/match_pattern.rs and add it to all match statements
• Add test cases for the language in crates/core/src/test.rs. This is a good time to add a few dozen test cases to ensure that the language is parsed correctly, and that the metavariable grammar is working.
  • cargo test --package marzano-core --lib -- test::simple_kotlin --exact --show-output

Greptile Summary

This is an auto-generated summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

[morgante]

We should use GritQL for this.

[Alex-ley-scrub]

Good point. I don't really know GritQL well enough, yet. Whereas regex, I know all too well 🤣

[morgante]

Thankfully this one is very simple:

`const allLanguages = [$langs]` where { $langs += `"foo"`}

[Alex-ley-scrub]

Very nice. Thanks. Might be worthwhile for me to spend a bit of time learning GritQL after this PR then!

[Alex-ley-scrub]

I'm just going to add "At least 10 test cases, including rewrites and metavariables." as you mentioned on the issue description. From your perspective, once I do that (assuming they all pass or are fixed as needed) would this PR be ready to merge? Or have I missed something else?

[morgante]

I think I'd opt to remove this file, since it will potentially require maintenance and doesn't really make things much faster/easier as-is.

[morgante]

@Alex-ley-scrub Can you remove this file? It's better to not point people in the wrong direction with a script for something that will probably become outdated quickly.

[Alex-ley-scrub]

yeah no worries, removed this file in: 16ce34d

as a small aside on this gritql pattern, for my general understanding of gritql, there's no built in sort() or sorted() command, right (https://docs.grit.io/language/functions#function-definitions) - i.e. to insert "Kotlin" in the "correct" place in this alphabetically sorted list? But we could do it with a custom JavaScript function
(https://docs.grit.io/language/functions#foreign-functions)?

`const allLanguages = [$langs]` where { $langs += `"Kotlin"`}

maybe like this? It almost works but not exactly:

https://app.grit.io/studio?key=CIQtWzXJuUibMJ6krsn9R

engine marzano(0.1)
language js

function add_lang($langs, $new_lang) js {
    // Use $var.text to access the binding's value
    let output = $langs.text.split(",");
    output.push($new_lang.text);
    return output.sort();
}

`const allLanguages = [$langs]` where { 
    $new_langs = add_lang($langs, `"Kotlin"`)
} => `const allLanguages = [ $new_langs ];`

[morgante]

Please also add at least one binary/CLI test in tests/apply.rs.

[greptile-apps]

LGTM

_{61 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[Alex-ley-scrub]

@morgante I finally got the time to debug this properly and figure out why the patterns weren't matching and make progress!
Now all my tests are passing 🎉 : https://github.com/getgrit/gritql/actions/runs/12643182237/job/35228762725?pr=573

But there are a bunch of clippy errors for code I didn't write: https://github.com/getgrit/gritql/actions/runs/12643182239/job/35228763160?pr=573

Do you want me to fix them? Are they new errors with a new compiler version or something? How else are they only just showing up now in my PR?

I had done a git merge upstream/main to get upstream changes that I didn't have and that I needed to resolve conflicts on - but the PR states "Merge is not an allowed merge method in this repository. This branch must not contain merge commits.". So, I also rebased and force-pushed. Although that warning is still there? Do I need to do anything else like squash my history or is that fine to just be done automatically by GitHub when the PR is approved and merged into main?

[morgante]

Thanks @Alex-ley-scrub for following up here - excited to see this land.

But there are a bunch of clippy errors for code I didn't write: https://github.com/getgrit/gritql/actions/runs/12643182239/job/35228763160?pr=573
Do you want me to fix them? Are they new errors with a new compiler version or something? How else are they only just showing up now in my PR?

Since they don't show up on main it would be good if you fix them.

I had done a git merge upstream/main to get upstream changes that I didn't have and that I needed to resolve conflicts on - but the PR states "Merge is not an allowed merge method in this repository. This branch must not contain merge commits.". > So, I also rebased and force-pushed. Although that warning is still there? Do I need to do anything else like squash my history or is that fine to just be done automatically by GitHub when the PR is approved and merged into main?

Don't worry about that, I always just squash changes once we merge.

[morgante]

@Alex-ley-scrub Can you remove this file? It's better to not point people in the wrong direction with a script for something that will probably become outdated quickly.

[morgante]

Actually feel free to ignore the clippy errors, I think they're related to an untracked upstream change.

[Alex-ley-scrub]

Thanks for merging 'main' into this branch @morgante looks like all tests pass and all the clippys errors are removed now as well 🎉 🙌