chore: wip

Author: chrisbbreuer

packages/launchpad/bin/cli.ts

@@ -25,6 +25,8 @@ const cli = new CAC('launchpad')
 cli.version(version)
 cli.help()
 
+//
+
 // Config command - show resolved user configuration
 cli
   .command('config', 'Show current Launchpad configuration')
@@ -49,6 +51,8 @@ cli
     }
   })
 
+// (parse moved to end)
+
 // Main installation command
 cli
   .command('install [packages...]', 'Install packages or set up development environment')
@@ -1377,19 +1381,10 @@ cli
     json?: boolean
   }) => {
     try {
-      const argv: string[] = []
-      if (options?.iterations)
-        argv.push('--iterations', String(options.iterations))
-      if (options?.depths)
-        argv.push('--depths', options.depths)
-      if (options?.verbose)
-        argv.push('--verbose')
-      if (options?.json)
-        argv.push('--json')
       const cmd = await resolveCommand('benchmark:file-detection')
       if (!cmd)
         return
-      const code = await cmd.run({ argv, env: process.env })
+      const code = await cmd.run({ argv: [], options, env: process.env })
       if (typeof code === 'number' && code !== 0)
         process.exit(code)
     }
@@ -1399,16 +1394,7 @@ cli
     }
   })
 
-// Parse CLI arguments
-try {
-  cli.version(version)
-  cli.help()
-  cli.parse()
-}
-catch (error) {
-  console.error('CLI error:', error instanceof Error ? error.message : String(error))
-  process.exit(1)
-}
+// NOTE: cli.parse() moved to the end of the file to ensure all commands are registered
 
 // Database management commands
 cli
@@ -1431,23 +1417,10 @@ cli
     password?: string
   }) => {
     try {
-      const argv: string[] = []
-      if (options?.name)
-        argv.push('--name', options.name)
-      if (options?.type)
-        argv.push('--type', options.type)
-      if (options?.host)
-        argv.push('--host', options.host)
-      if (options?.port)
-        argv.push('--port', String(options.port))
-      if (options?.user)
-        argv.push('--user', options.user)
-      if (options?.password)
-        argv.push('--password', options.password)
       const cmd = await resolveCommand('db:create')
       if (!cmd)
         return
-      const code = await cmd.run({ argv, env: process.env })
+      const code = await cmd.run({ argv: [], options, env: process.env })
       if (typeof code === 'number' && code !== 0)
         process.exit(code)
     }
@@ -1456,3 +1429,12 @@ cli
       process.exit(1)
     }
   })
+
+// Parse CLI arguments (must be last)
+try {
+  cli.parse()
+}
+catch (error) {
+  console.error('CLI error:', error instanceof Error ? error.message : String(error))
+  process.exit(1)
+}

packages/launchpad/src/cli/types.ts

@@ -1,5 +1,8 @@
 export interface CommandContext {
+  // Backward-compat: most commands expect argv to exist
   argv: string[]
+  // Preferred: structured options parsed by the CLI
+  options?: Record<string, any>
   env: NodeJS.ProcessEnv
 }
 
@@ -8,7 +11,7 @@ export interface Command {
   aliases?: string[]
   description?: string
   help?: string
-  run(ctx: CommandContext): Promise<number> | number
+  run: (ctx: CommandContext) => Promise<number> | number
 }
 
-export type CommandModule = { default: Command }
+export interface CommandModule { default: Command }

packages/launchpad/src/commands/benchmark/file-detection.ts

@@ -1,41 +1,23 @@
 import type { Command } from '../../cli/types'
 
-function parseArgs(argv: string[]): { depths?: number[], iterations?: number, verbose?: boolean, json?: boolean } {
-  const result: { depths?: number[], iterations?: number, verbose?: boolean, json?: boolean } = {}
-  for (let i = 0; i < argv.length; i++) {
-    const a = argv[i]
-    if (a === '--verbose') {
-      result.verbose = true
-    }
-    else if (a === '--json') {
-      result.json = true
-    }
-    else if (a === '--iterations' && i + 1 < argv.length) {
-      const v = Number.parseInt(argv[++i], 10)
-      if (!Number.isNaN(v))
-        result.iterations = v
-    }
-    else if (a === '--depths' && i + 1 < argv.length) {
-      const v = String(argv[++i])
-      const depths = v.split(',').map(d => Number.parseInt(d.trim(), 10)).filter(d => !Number.isNaN(d))
-      if (depths.length > 0)
-        result.depths = depths
-    }
-  }
-  return result
-}
-
 const command: Command = {
   name: 'benchmark:file-detection',
   description: 'Benchmark file detection performance (shell vs Bun)',
-  async run({ argv }) {
+  async run({ options }) {
     const { runFileDetectionBenchmark } = await import('../../dev/benchmark')
-    const opts = parseArgs(argv)
+    const depths = typeof options?.depths === 'string'
+      ? options.depths.split(',').map((d: string) => Number.parseInt(d.trim(), 10)).filter((d: number) => !Number.isNaN(d))
+      : undefined
+    const iterations = typeof options?.iterations === 'string'
+      ? Number.parseInt(options.iterations, 10)
+      : typeof options?.iterations === 'number'
+        ? options.iterations
+        : undefined
     await runFileDetectionBenchmark({
-      depths: opts.depths,
-      iterations: opts.iterations,
-      verbose: opts.verbose,
-      json: opts.json,
+      depths,
+      iterations,
+      verbose: Boolean(options?.verbose),
+      json: Boolean(options?.json),
     })
     return 0
   },

packages/launchpad/src/commands/cache/clean.ts

@@ -3,18 +3,26 @@ import type { Command } from '../../cli/types'
 const cmd: Command = {
   name: 'cache:clean',
   description: 'Clean up old cached packages based on age and size limits',
-  async run({ argv }) {
+  async run({ argv, options }) {
     const { getCacheStats, cleanupCache } = await import('../../cache')
 
+    // Strongly type options
+    interface Opts { maxAge?: number | string; maxSize?: number | string; dryRun?: boolean }
+    const opts = (options ?? {}) as Opts
+
     const getArgValue = (flag: string): string | undefined => {
       const idx = argv.indexOf(flag)
       if (idx !== -1 && idx + 1 < argv.length) return argv[idx + 1]
       return undefined
     }
 
-    const maxAge = getArgValue('--max-age')
-    const maxSize = getArgValue('--max-size')
-    const dryRun = argv.includes('--dry-run')
+    const maxAge = typeof opts.maxAge === 'number' ? String(opts.maxAge)
+      : typeof opts.maxAge === 'string' ? opts.maxAge
+      : getArgValue('--max-age')
+    const maxSize = typeof opts.maxSize === 'number' ? String(opts.maxSize)
+      : typeof opts.maxSize === 'string' ? opts.maxSize
+      : getArgValue('--max-size')
+    const dryRun = typeof opts.dryRun === 'boolean' ? opts.dryRun : argv.includes('--dry-run')
 
     const maxAgeDays = maxAge ? Number.parseInt(maxAge, 10) : 30
     const maxSizeGB = maxSize ? Number.parseFloat(maxSize) : 5

packages/launchpad/src/commands/cache/clear.ts

@@ -1,19 +1,25 @@
+/* eslint-disable no-console */
 import type { Command } from '../../cli/types'
 
 const cmd: Command = {
   name: 'cache:clear',
   description: 'Clear all cached packages and downloads',
-  async run({ argv }) {
+  async run({ argv, options }) {
     const fs = await import('node:fs')
     const path = await import('node:path')
     const os = await import('node:os')
     const { config } = await import('../../config')
 
-    const verbose = argv.includes('--verbose')
-    const force = argv.includes('--force')
-    const dryRun = argv.includes('--dry-run')
+    // Strongly type options
+    interface Opts { verbose?: boolean, force?: boolean, dryRun?: boolean }
+    const opts = (options ?? {}) as Opts
 
-    if (verbose) config.verbose = true
+    const verbose = typeof opts.verbose === 'boolean' ? opts.verbose : argv.includes('--verbose')
+    const force = typeof opts.force === 'boolean' ? opts.force : argv.includes('--force')
+    const dryRun = typeof opts.dryRun === 'boolean' ? opts.dryRun : argv.includes('--dry-run')
+
+    if (verbose)
+      config.verbose = true
 
     const homeDir = os.homedir()
     const cacheDir = path.join(homeDir, '.cache', 'launchpad')
@@ -35,7 +41,8 @@ const cmd: Command = {
     let fileCount = 0
 
     const calculateCacheStats = (dir: string) => {
-      if (!fs.existsSync(dir)) return
+      if (!fs.existsSync(dir))
+        return
       try {
         const stack = [dir]
         while (stack.length > 0) {
@@ -63,7 +70,8 @@ const cmd: Command = {
       catch { /* ignore */ }
     }
 
-    if (fs.existsSync(cacheDir)) calculateCacheStats(cacheDir)
+    if (fs.existsSync(cacheDir))
+      calculateCacheStats(cacheDir)
 
     const formatSize = (bytes: number): string => {
       const units = ['B', 'KB', 'MB', 'GB']
@@ -84,8 +92,10 @@ const cmd: Command = {
         console.log(`   • Cache directory: ${cacheDir}`)
         console.log('')
         console.log('Would remove:')
-        if (fs.existsSync(bunCacheDir)) console.log(`   • Bun cache: ${bunCacheDir}`)
-        if (fs.existsSync(packageCacheDir)) console.log(`   • Package cache: ${packageCacheDir}`)
+        if (fs.existsSync(bunCacheDir))
+          console.log(`   • Bun cache: ${bunCacheDir}`)
+        if (fs.existsSync(packageCacheDir))
+          console.log(`   • Package cache: ${packageCacheDir}`)
       }
       else {
         console.log('📭 No cache found - nothing to clear')

packages/launchpad/src/commands/dev/check-updates.ts renamed to packages/launchpad/src/commands/check-updates.ts

@@ -1,11 +1,11 @@
-import type { Command } from '../../cli/types'
+import type { Command } from '../cli/types'
 
 const cmd: Command = {
-  name: 'dev:check-updates',
+  name: 'check-updates',
   aliases: [],
   description: 'Check global dependencies for updates (TTL-based); auto-update if enabled',
   async run({ argv, env }) {
-    const { checkAndMaybeUpdate } = await import('../../dev/update-check')
+    const { checkAndMaybeUpdate } = await import('../dev/update-check')
 
     // Flags (optional): --dry-run to skip network, --auto-update to force on
     const dryRun = argv.includes('--dry-run') || env.LAUNCHPAD_SKIP_NETWORK === '1'