Skip to content

Fix hass-subpage toolbar position #27003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

Fix hass-subpage toolbar position #27003

merged 1 commit into from
Sep 11, 2025

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Sep 11, 2025 •
edited
Loading

Breaking change

Proposed change

Fixes unintential issue from safe area bar changes: https://github.com/home-assistant/frontend/pull/26816/files#diff-481a8f354ac84d4b24fd39f8d5258e2491d30c2ffe148c5442b991d72e0321bb

default:
image
image

with safe areas:
image
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration



Additional information



    

  • This PR fixes or closes issue: fixes #
    • 

  • This PR is related to issue or discussion:
    • 

  • Link to documentation pull request:
    • 



Checklist



    

  •  The code change is tested and works locally.
    • 

  •  There is no commented out code in this PR.
    • 

  •  Tests have been added to verify that the new code works.
    • 



If user exposed functionality or configuration variables are added/changed:



    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  




      

       
            



      

  
        





      

  
            


  

  

    
  


  

      


  This was referenced Sep 11, 2025





  


  

      
     Closed

  






      







  


  

      

  
  Open

  






  




  



  
    
  
  

    

  timmo001 

      added a commit
      that referenced
      this pull request

    
      Sep 11, 2025
    
    

      


  

    

      


  

      
        @timmo001
  





      

        
          Apply changes from #27003
        


      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          62e1661
        
      

    

  




    

  




  



  
    
  
  

    

  timmo001 

      added a commit
      that referenced
      this pull request

    
      Sep 11, 2025
    
    

      


  

    

      


  

      
        @timmo001
  





      

        
          Safe area: containers and panels
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          97cb292
        
      

    

  

    

      
This commit squashes the following development history:

1e78af3 - Restore, moved to #26969
d672d9f - Restore
53ee5fb - Restore
16b4eb9 - Restore
8d8b13f - Restore
62e1661 - Apply changes from #27003
f5ee79a - Fix
6067868 - Fix
766ed6a - Fix
f76bd4f - Fix fabs
1879fd0 - Fix
ea3ee6d - Add safe areas to ha-hanel-custom
aa3384b - Add missing
c9a7f76 - Fix
78351fd - Fix
59789d3 - Fix
1c7aabd - Remove
eaf1373 - Fix
8481a93 - Fix
fe7df1f - Remove
69f244f - Restore
2eb936b - Adjust
b093506 - Fix
c0504bb - Clean
b0773d7 - Fix
4caa4a4 - make sure narrow is passed
8885f6b - Add safe areas to 2 pane fixed
62df70f - Clean
a87e68d - FIx
5086be0 - Fix energy
ac3478e - Fix
0f28098 - Restore
b65ba3d - Restore
b0e1ea6 - Restore
7bb78d1 - Fix
26c95df - Update
7369c79 - Remove
b5f31da - Fix
40cfc43 - Set top level padding instead of individual panels
83b4972 - Restore
25db158 - Fix
8c9c398 - Set top level app bar padding instead of individual panels
b7a1b27 - Remove
1e93687 - Device
1482502 - Integration page
98dc1bf - Fix
1c3de13 - Add
a08bee4 - Remove
0d46243 - Area subpage
4bfd608 - Areas fix
b5cbcda - Fix
9fb2720 - Add safe areas to script editor
7c3bc94 - Add safe areas to scene editor
1cf1b99 - Fix mobile for automation editors
4413bd4 - Add safe areas to automation editor
2e69533 - Add safe areas to blueprint editor
989776d - Add config section padding
6692b7c - Fix header row
22337b5 - Fix calendar
414e058 - Fix pane
f09ae0e - Fix calendar
fb5a984 - Fix pane
1daee18 - Todo fab
6f52cb4 - Todo content
9b317c5 - Media browser
0f8ca24 - Fix history panel
cd78437 - Fix logbook
b8d47ec - Fix
d15e931 - Safe area: dashboard view container should only apply left safe area when in full view

Summary of changes:
- Add narrow property to top app bar components for conditional safe area padding
- Update safe area inset calculations to use fallback values (0px) for better compatibility
- Fix content height calculations to account for safe area insets
- Apply safe area padding conditionally based on narrow state
- Update FAB positioning to respect safe area insets
- Ensure proper spacing and layout on mobile devices with notches/dynamic islands

    




    

  




    

    

      
    

    


      


          @timmo001
timmo001




        changed the title
Fix hass-subpage toolbar position

Safe area: Fix hass-subpage toolbar position


      Sep 11, 2025

    

  



    

    

      
    

    


      


          @timmo001
timmo001




        changed the title
Safe area: Fix hass-subpage toolbar position

Fix hass-subpage toolbar position


      Sep 11, 2025

    

  








      

  
        





      

  
          
 
  

    
  

  


        
        @wendevlin
  wendevlin



        merged commit 5bcffd0
      into

      
  
    dev
  


    Sep 11, 2025

      

        16 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @wendevlin
  wendevlin


    
    deleted the
    
      
        fix/safe-area-hass-subpage-toolbar
    
    branch

    September 11, 2025 13:26    
    




  



  
    
  
  

    

  timmo001 

      added a commit
      that referenced
      this pull request

    
      Sep 11, 2025
    
    

      


  

    

      


  

      
        @timmo001
  





      

        
          Safe area: containers and panels
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          4c6cbf9
        
      

    

  

    

      
This commit squashes the following development history:

1e78af3 - Restore, moved to #26969
d672d9f - Restore
53ee5fb - Restore
16b4eb9 - Restore
8d8b13f - Restore
62e1661 - Apply changes from #27003
f5ee79a - Fix
6067868 - Fix
766ed6a - Fix
f76bd4f - Fix fabs
1879fd0 - Fix
ea3ee6d - Add safe areas to ha-hanel-custom
aa3384b - Add missing
c9a7f76 - Fix
78351fd - Fix
59789d3 - Fix
1c7aabd - Remove
eaf1373 - Fix
8481a93 - Fix
fe7df1f - Remove
69f244f - Restore
2eb936b - Adjust
b093506 - Fix
c0504bb - Clean
b0773d7 - Fix
4caa4a4 - make sure narrow is passed
8885f6b - Add safe areas to 2 pane fixed
62df70f - Clean
a87e68d - FIx
5086be0 - Fix energy
ac3478e - Fix
0f28098 - Restore
b65ba3d - Restore
b0e1ea6 - Restore
7bb78d1 - Fix
26c95df - Update
7369c79 - Remove
b5f31da - Fix
40cfc43 - Set top level padding instead of individual panels
83b4972 - Restore
25db158 - Fix
8c9c398 - Set top level app bar padding instead of individual panels
b7a1b27 - Remove
1e93687 - Device
1482502 - Integration page
98dc1bf - Fix
1c3de13 - Add
a08bee4 - Remove
0d46243 - Area subpage
4bfd608 - Areas fix
b5cbcda - Fix
9fb2720 - Add safe areas to script editor
7c3bc94 - Add safe areas to scene editor
1cf1b99 - Fix mobile for automation editors
4413bd4 - Add safe areas to automation editor
2e69533 - Add safe areas to blueprint editor
989776d - Add config section padding
6692b7c - Fix header row
22337b5 - Fix calendar
414e058 - Fix pane
f09ae0e - Fix calendar
fb5a984 - Fix pane
1daee18 - Todo fab
6f52cb4 - Todo content
9b317c5 - Media browser
0f8ca24 - Fix history panel
cd78437 - Fix logbook
b8d47ec - Fix
d15e931 - Safe area: dashboard view container should only apply left safe area when in full view

Summary of changes:
- Add narrow property to top app bar components for conditional safe area padding
- Update safe area inset calculations to use fallback values (0px) for better compatibility
- Fix content height calculations to account for safe area insets
- Apply safe area padding conditionally based on narrow state
- Update FAB positioning to respect safe area insets
- Ensure proper spacing and layout on mobile devices with notches/dynamic islands

    




    

  




  



  
    
  
  

    

  MindFreeze 

      pushed a commit
      that referenced
      this pull request

    
      Sep 15, 2025
    
    

      


  

    

      


  

      
        @timmo001
  





      

        
          Safe area: containers and panels (#26971)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          c09ec54
        
      

    

  

    

      
This commit squashes the following development history:

1e78af3 - Restore, moved to #26969
d672d9f - Restore
53ee5fb - Restore
16b4eb9 - Restore
8d8b13f - Restore
62e1661 - Apply changes from #27003
f5ee79a - Fix
6067868 - Fix
766ed6a - Fix
f76bd4f - Fix fabs
1879fd0 - Fix
ea3ee6d - Add safe areas to ha-hanel-custom
aa3384b - Add missing
c9a7f76 - Fix
78351fd - Fix
59789d3 - Fix
1c7aabd - Remove
eaf1373 - Fix
8481a93 - Fix
fe7df1f - Remove
69f244f - Restore
2eb936b - Adjust
b093506 - Fix
c0504bb - Clean
b0773d7 - Fix
4caa4a4 - make sure narrow is passed
8885f6b - Add safe areas to 2 pane fixed
62df70f - Clean
a87e68d - FIx
5086be0 - Fix energy
ac3478e - Fix
0f28098 - Restore
b65ba3d - Restore
b0e1ea6 - Restore
7bb78d1 - Fix
26c95df - Update
7369c79 - Remove
b5f31da - Fix
40cfc43 - Set top level padding instead of individual panels
83b4972 - Restore
25db158 - Fix
8c9c398 - Set top level app bar padding instead of individual panels
b7a1b27 - Remove
1e93687 - Device
1482502 - Integration page
98dc1bf - Fix
1c3de13 - Add
a08bee4 - Remove
0d46243 - Area subpage
4bfd608 - Areas fix
b5cbcda - Fix
9fb2720 - Add safe areas to script editor
7c3bc94 - Add safe areas to scene editor
1cf1b99 - Fix mobile for automation editors
4413bd4 - Add safe areas to automation editor
2e69533 - Add safe areas to blueprint editor
989776d - Add config section padding
6692b7c - Fix header row
22337b5 - Fix calendar
414e058 - Fix pane
f09ae0e - Fix calendar
fb5a984 - Fix pane
1daee18 - Todo fab
6f52cb4 - Todo content
9b317c5 - Media browser
0f8ca24 - Fix history panel
cd78437 - Fix logbook
b8d47ec - Fix
d15e931 - Safe area: dashboard view container should only apply left safe area when in full view

Summary of changes:
- Add narrow property to top app bar components for conditional safe area padding
- Update safe area inset calculations to use fallback values (0px) for better compatibility
- Fix content height calculations to account for safe area insets
- Apply safe area padding conditionally based on narrow state
- Update FAB positioning to respect safe area insets
- Ensure proper spacing and layout on mobile devices with notches/dynamic islands

    




    

  













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    


        

    


  
      @wendevlin
  
    wendevlin



    
      
        
      
    
    wendevlin approved these changes

  



      






    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    cla-signed









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      3 participants
    

    

        
          @timmo001 
        
          @wendevlin