-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Safe area: dialogs #26814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe area: dialogs #26814
Conversation
…s, more-info top margin)
src/components/ha-dialog.ts
Outdated
| margin-top: var(--safe-area-inset-top); | ||
| margin-right: var(--safe-area-inset-right); | ||
| margin-left: var(--safe-area-inset-left); | ||
| margin-bottom: var(--safe-area-inset-bottom); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get why min-height and max-height are inside @media but I think the margins should be outside. There may be tablets or other large screen devices with safe area insets
|
Fixed using min-width for container instead, and using padding for top and bottom. Also fixed two lit-virtualizer height issues |
|
I think this may be causing double safe areas now as other components set The best way to solve this would be to remove the calculations from the other components and only do this once in |












Breaking change
Proposed change
Part of continuation of #25566
Applies safe-area insets to dialogs and more-info components, ensuring content doesn't get clipped on devices with display cutouts while maintaining desktop appearance.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: