fix (mvTheme): Pop must be done in the reverse order of push.

v-ein · hoffstadt · commit 404ae17463e0 · 2026-01-25T19:14:40.000-06:00
This is needed to properly restore _specificComponentPtr back when there are multiple components with the same specificType.
diff --git a/src/mvThemes.cpp b/src/mvThemes.cpp
@@ -86,9 +86,9 @@ void mvTheme::push_theme_components()
 void mvTheme::pop_theme_components()
 {
 
-	for (auto& child : childslots[1])
+	for (auto it = childslots[1].rbegin(); it != childslots[1].rend(); it++)
 	{
-		auto comp = static_cast<mvThemeComponent*>(child.get());
+		auto comp = static_cast<mvThemeComponent*>(it->get());
 		if (comp->_specificType == (int)mvAppItemType::All || comp->_specificType == _specificType)
 		{
 			if (_specificEnabled == comp->_specificEnabled)

Original file line number	Diff line number	Diff line change
`@@ -86,9 +86,9 @@ void mvTheme::push_theme_components()`
`86`	`86`	`void mvTheme::pop_theme_components()`
`87`	`87`	`{`
`88`	`88`
`89`		`- for (auto& child : childslots[1])`
	`89`	`+ for (auto it = childslots[1].rbegin(); it != childslots[1].rend(); it++)`
`90`	`90`	`{`
`91`		`- auto comp = static_cast<mvThemeComponent*>(child.get());`
	`91`	`+ auto comp = static_cast<mvThemeComponent*>(it->get());`
`92`	`92`	`if (comp->_specificType == (int)mvAppItemType::All \|\| comp->_specificType == _specificType)`
`93`	`93`	`{`
`94`	`94`	`if (_specificEnabled == comp->_specificEnabled)`