Aha, so, we have custom_fee (the parent) and its subclasses custom_fixed_fee, custom_fractional_fee, custom_royalty_fee

Therefore, we need to have integration tests for the base class (custom_fee), plus (separate test files for) its subclasses (which are out of scope of this issue)

We need to verify that the base class (custom_fee) works as expected with the Hedera network and various operations all together

For example there are various things we could test:

class CustomFee(ABC):
def init(
self,
fee_collector_account_id: typing.Optional[AccountId] = None,
all_collectors_are_exempt: bool = False,
):
test_init_sets_default_values_correctly
test_init_assigns_provided_fee_collector_and_exempt_flag

def set_fee_collector_account_id(self, account_id: AccountId) -> "CustomFee":

we should:
test_set_fee_collector_account_id_updates_field_and_returns_self

def set_all_collectors_are_exempt(self, exempt: bool) -> "CustomFee":

we should:
test_set_all_collectors_are_exempt_updates_flag_and_returns_self

@staticmethod
def _from_proto(custom_fee: "CustomFeeProto") -> "CustomFee":

test_from_proto_dispatches_to_correct_subclass_fixed_fee
test_from_proto_dispatches_to_correct_subclass_fractional_fee
test_from_proto_dispatches_to_correct_subclass_royalty_fee
test_from_proto_raises_value_error_on_unrecognized_case

def _get_fee_collector_account_id_protobuf(self) -> typing.Optional[AccountID]:

test_get_fee_collector_account_id_protobuf_returns_none_if_not_set
test_get_fee_collector_account_id_protobuf_returns_proto_if_set

@abstractmethod
def _to_proto(self) -> "CustomFeeProto":  
    ...

handled in subclasses
test_custom_fee_cannot_be_instantiated_directly

def _validate_checksums(self, client: Client) -> None:

test_validate_checksums_invokes_account_validation
test_validate_checksums_does_not_call_validate_if_no_account_set

def __eq__(self, other: object) -> bool:

test_eq_returns_true_for_equal_instances
test_eq_returns_false_for_different_collector_ids
test_eq_returns_false_for_different_exempt_flag
test_eq_returns_not_implemented_for_other_types

So what is the most important things to add to an integration test?
Talking with the hedera network

converting to proto
converting from proto
validate checksums

Everything that is hanlded locally is better placed in a unit test.
You can review the custom fee unit tests, and if there are any missing tests, open up an issue.

def test_custom_fee_can_execute()
def test_from_proto_dispatches_to_correct_subclass_fixed_fee(test_account_id):
def test_from_proto_dispatches_to_correct_subclass_fractional_fee(test_account_id):
def test_from_proto_dispatches_to_correct_subclass_royalty_fee(test_account_id):
def test_get_fee_collector_account_id_protobuf_returns_proto_if_set(test_account_id):
def test_validate_checksums_invokes_account_validation(testnet_client, test_account_id):

as you can see, you'll need account ids and a client set up
You can generate them in the test, or you can refer/add to tests/integration/utils_for_test.py

It's probably easiest to wait until the examples are connecting to the hedera network, examples can be thought of as a very loose way of testing functionality with the hedera network so there will be some use in studying them too - as well as other integration tests

Create integration tests for src/hiero_sdk_python/tokens/custom_fee.py #584

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions