Skip to content

Commit dfdc439

Browse files
dreab8dreab8
committed
HHH-13788 Add test for issue
1 parent 916849a commit dfdc439

2 files changed

Lines changed: 288 additions & 0 deletions

File tree

‎hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaUpdateWithUseJdbcMetadataDefaultsSettingToFalseAndQuotedNameTest.java‎

Lines changed: 147 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,147 @@
1+
/*
2+
* Hibernate, Relational Persistence for Idiomatic Java
3+
*
4+
* License: GNU Lesser General Public License (LGPL), version 2.1 or later
5+
* See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
6+
*/
7+
package org.hibernate.test.schemaupdate;
8+
9+
import java.io.File;
10+
import java.io.IOException;
11+
import java.nio.file.Files;
12+
import java.util.EnumSet;
13+
import java.util.regex.Matcher;
14+
import java.util.regex.Pattern;
15+
import javax.persistence.Column;
16+
import javax.persistence.Entity;
17+
import javax.persistence.Id;
18+
19+
import org.hibernate.boot.MetadataSources;
20+
import org.hibernate.boot.registry.StandardServiceRegistry;
21+
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
22+
import org.hibernate.boot.spi.MetadataImplementor;
23+
import org.hibernate.cfg.AvailableSettings;
24+
import org.hibernate.dialect.Dialect;
25+
import org.hibernate.tool.hbm2ddl.SchemaExport;
26+
import org.hibernate.tool.hbm2ddl.SchemaUpdate;
27+
import org.hibernate.tool.hbm2ddl.SchemaValidator;
28+
import org.hibernate.tool.schema.JdbcMetadaAccessStrategy;
29+
import org.hibernate.tool.schema.TargetType;
30+
31+
import org.hibernate.testing.TestForIssue;
32+
import org.junit.After;
33+
import org.junit.Before;
34+
import org.junit.Test;
35+
import org.junit.runner.RunWith;
36+
import org.junit.runners.Parameterized;
37+
38+
import static org.hamcrest.core.Is.is;
39+
import static org.junit.Assert.assertThat;
40+
41+
@TestForIssue(jiraKey = "HHH-13788")
42+
@RunWith(Parameterized.class)
43+
public class SchemaUpdateWithUseJdbcMetadataDefaultsSettingToFalseAndQuotedNameTest {
44+
@Parameterized.Parameters
45+
public static String[] parameters() {
46+
return new String[] {
47+
JdbcMetadaAccessStrategy.GROUPED.toString(),
48+
JdbcMetadaAccessStrategy.INDIVIDUALLY.toString()
49+
};
50+
}
51+
52+
@Parameterized.Parameter
53+
public String jdbcMetadataExtractorStrategy;
54+
55+
private File updateOutputFile;
56+
private File createOutputFile;
57+
private StandardServiceRegistry ssr;
58+
private MetadataImplementor metadata;
59+
60+
@Before
61+
public void setUp() throws IOException {
62+
createOutputFile = File.createTempFile( "create_script", ".sql" );
63+
createOutputFile.deleteOnExit();
64+
updateOutputFile = File.createTempFile( "update_script", ".sql" );
65+
updateOutputFile.deleteOnExit();
66+
ssr = new StandardServiceRegistryBuilder()
67+
.applySetting( "hibernate.temp.use_jdbc_metadata_defaults", "false" )
68+
.applySetting( AvailableSettings.SHOW_SQL, "true" )
69+
.applySetting(
70+
AvailableSettings.HBM2DDL_JDBC_METADATA_EXTRACTOR_STRATEGY,
71+
jdbcMetadataExtractorStrategy
72+
)
73+
.build();
74+
75+
final MetadataSources metadataSources = new MetadataSources( ssr );
76+
metadataSources.addAnnotatedClass( AnotherTestEntity.class );
77+
78+
metadata = (MetadataImplementor) metadataSources.buildMetadata();
79+
metadata.validate();
80+
}
81+
82+
@After
83+
public void tearDown() {
84+
new SchemaExport().setHaltOnError( true )
85+
.setFormat( false )
86+
.drop( EnumSet.of( TargetType.DATABASE ), metadata );
87+
StandardServiceRegistryBuilder.destroy( ssr );
88+
}
89+
90+
@Test
91+
public void testSchemaUpdateDoesNotTryToRecreateExistingTables()
92+
throws Exception {
93+
createSchema();
94+
95+
new SchemaUpdate().setHaltOnError( true )
96+
.setOutputFile( updateOutputFile.getAbsolutePath() )
97+
.setFormat( false )
98+
.execute( EnumSet.of( TargetType.DATABASE, TargetType.SCRIPT ), metadata );
99+
100+
checkNoUpdateStatementHasBeenGenerated();
101+
}
102+
103+
private void checkNoUpdateStatementHasBeenGenerated() throws IOException {
104+
final String fileContent = new String( Files.readAllBytes( updateOutputFile.toPath() ) );
105+
assertThat(
106+
"The update output file should be empty because the db schema had already been generated and the domain model was not modified",
107+
fileContent,
108+
is( "" )
109+
);
110+
}
111+
112+
private void createSchema() throws Exception {
113+
new SchemaUpdate().setHaltOnError( true )
114+
.setOutputFile( createOutputFile.getAbsolutePath() )
115+
.execute( EnumSet.of( TargetType.DATABASE, TargetType.SCRIPT ), metadata );
116+
new SchemaValidator().validate( metadata );
117+
checkSchemaHasBeenGenerated();
118+
}
119+
120+
private void checkSchemaHasBeenGenerated() throws Exception {
121+
String fileContent = new String( Files.readAllBytes( createOutputFile.toPath() ) );
122+
final Dialect dialect = metadata.getDatabase().getDialect();
123+
Pattern fileContentPattern;
124+
if ( dialect.openQuote() == '[' ) {
125+
fileContentPattern = Pattern.compile( "create( (column|row))? table " + "\\[" + "another_test_entity" + "\\]" );
126+
}
127+
else {
128+
fileContentPattern = Pattern.compile( "create( (column|row))? table " + dialect.openQuote() + "another_test_entity" + dialect
129+
.closeQuote() );
130+
}
131+
Matcher fileContentMatcher = fileContentPattern.matcher( fileContent.toLowerCase() );
132+
assertThat(
133+
"The schema has not been correctly generated, Script file : " + fileContent.toLowerCase(),
134+
fileContentMatcher.find(),
135+
is( true )
136+
);
137+
}
138+
139+
@Entity(name = "`Another_Test_Entity`")
140+
public static class AnotherTestEntity {
141+
@Id
142+
private Long id;
143+
144+
@Column(name = "`another_NAME`")
145+
private String name;
146+
}
147+
}

‎hibernate-core/src/test/java/org/hibernate/test/schemaupdate/SchemaUpdateWithUseJdbcMetadataDefaultsSettingToFalseTest.java‎

Lines changed: 141 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,141 @@
1+
/*
2+
* Hibernate, Relational Persistence for Idiomatic Java
3+
*
4+
* License: GNU Lesser General Public License (LGPL), version 2.1 or later
5+
* See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
6+
*/
7+
package org.hibernate.test.schemaupdate;
8+
9+
import java.io.File;
10+
import java.io.IOException;
11+
import java.nio.file.Files;
12+
import java.util.EnumSet;
13+
import java.util.regex.Matcher;
14+
import java.util.regex.Pattern;
15+
import javax.persistence.Column;
16+
import javax.persistence.Entity;
17+
import javax.persistence.Id;
18+
19+
import org.hibernate.boot.MetadataSources;
20+
import org.hibernate.boot.registry.StandardServiceRegistry;
21+
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
22+
import org.hibernate.boot.spi.MetadataImplementor;
23+
import org.hibernate.cfg.AvailableSettings;
24+
import org.hibernate.tool.hbm2ddl.SchemaExport;
25+
import org.hibernate.tool.hbm2ddl.SchemaUpdate;
26+
import org.hibernate.tool.hbm2ddl.SchemaValidator;
27+
import org.hibernate.tool.schema.JdbcMetadaAccessStrategy;
28+
import org.hibernate.tool.schema.TargetType;
29+
30+
import org.hibernate.testing.TestForIssue;
31+
import org.junit.After;
32+
import org.junit.Before;
33+
import org.junit.Test;
34+
import org.junit.runner.RunWith;
35+
import org.junit.runners.Parameterized;
36+
37+
import static org.hamcrest.core.Is.is;
38+
import static org.junit.Assert.assertThat;
39+
40+
/**
41+
* @author Andrea Boriero
42+
*/
43+
@TestForIssue(jiraKey = "HHH-13788")
44+
@RunWith(Parameterized.class)
45+
public class SchemaUpdateWithUseJdbcMetadataDefaultsSettingToFalseTest {
46+
47+
@Parameterized.Parameters
48+
public static String[] parameters() {
49+
return new String[] {
50+
JdbcMetadaAccessStrategy.GROUPED.toString(),
51+
JdbcMetadaAccessStrategy.INDIVIDUALLY.toString()
52+
};
53+
}
54+
55+
@Parameterized.Parameter
56+
public String jdbcMetadataExtractorStrategy;
57+
58+
private File updateOutputFile;
59+
private File createOutputFile;
60+
private StandardServiceRegistry ssr;
61+
private MetadataImplementor metadata;
62+
63+
@Before
64+
public void setUp() throws IOException {
65+
createOutputFile = File.createTempFile( "create_script", ".sql" );
66+
createOutputFile.deleteOnExit();
67+
updateOutputFile = File.createTempFile( "update_script", ".sql" );
68+
updateOutputFile.deleteOnExit();
69+
ssr = new StandardServiceRegistryBuilder()
70+
.applySetting( "hibernate.temp.use_jdbc_metadata_defaults", "false" )
71+
.applySetting( AvailableSettings.SHOW_SQL, "true" )
72+
.applySetting(
73+
AvailableSettings.HBM2DDL_JDBC_METADATA_EXTRACTOR_STRATEGY,
74+
jdbcMetadataExtractorStrategy
75+
)
76+
.build();
77+
78+
final MetadataSources metadataSources = new MetadataSources( ssr );
79+
metadataSources.addAnnotatedClass( TestEntity.class );
80+
81+
metadata = (MetadataImplementor) metadataSources.buildMetadata();
82+
metadata.validate();
83+
}
84+
85+
@After
86+
public void tearDown() {
87+
new SchemaExport().setHaltOnError( true )
88+
.setFormat( false )
89+
.drop( EnumSet.of( TargetType.DATABASE ), metadata );
90+
StandardServiceRegistryBuilder.destroy( ssr );
91+
}
92+
93+
@Test
94+
public void testSchemaUpdateDoesNotTryToRecreateExistingTables()
95+
throws Exception {
96+
createSchema();
97+
98+
new SchemaUpdate().setHaltOnError( true )
99+
.setOutputFile( updateOutputFile.getAbsolutePath() )
100+
.setFormat( false )
101+
.execute( EnumSet.of( TargetType.DATABASE, TargetType.SCRIPT ), metadata );
102+
103+
checkNoUpdateStatementHasBeenGenerated();
104+
}
105+
106+
private void checkNoUpdateStatementHasBeenGenerated() throws IOException {
107+
final String fileContent = new String( Files.readAllBytes( updateOutputFile.toPath() ) );
108+
assertThat(
109+
"The update output file should be empty because the db schema had already been generated and the domain model was not modified",
110+
fileContent,
111+
is( "" )
112+
);
113+
}
114+
115+
private void createSchema() throws Exception {
116+
new SchemaUpdate().setHaltOnError( true )
117+
.setOutputFile( createOutputFile.getAbsolutePath() )
118+
.execute( EnumSet.of( TargetType.DATABASE, TargetType.SCRIPT ), metadata );
119+
new SchemaValidator().validate( metadata );
120+
checkSchemaHasBeenGenerated();
121+
}
122+
123+
private void checkSchemaHasBeenGenerated() throws Exception {
124+
String fileContent = new String( Files.readAllBytes( createOutputFile.toPath() ) );
125+
Pattern fileContentPattern = Pattern.compile( "create( (column|row))? table my_test_entity" );
126+
Matcher fileContentMatcher = fileContentPattern.matcher( fileContent.toLowerCase() );
127+
assertThat(
128+
"The schema has not been correctly generated, Script file : " + fileContent.toLowerCase(),
129+
fileContentMatcher.find(),
130+
is( true )
131+
);
132+
}
133+
134+
@Entity(name = "My_Test_Entity")
135+
public static class TestEntity {
136+
@Id
137+
private Long id;
138+
139+
private String name;
140+
}
141+
}

0 commit comments

Comments
 (0)