Skip to content

Upgrading to Bootstrap and Bootswatch 5.2.2 and to Bootstrap Icons 1.9.1 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2022
Merged

Upgrading to Bootstrap and Bootswatch 5.2.2 and to Bootstrap Icons 1.9.1 #257

merged 1 commit into from
Nov 13, 2022

Conversation

@PanderMusubi
Copy link
Collaborator

@PanderMusubi PanderMusubi commented Nov 1, 2022

No description provided.

@PanderMusubi PanderMusubi mentioned this pull request Nov 1, 2022
Closed
@PanderMusubi PanderMusubi force-pushed the bs522_icons191 branch 2 times, most recently from 18a063f to 8b6e76d Compare November 2, 2022 11:49
@PanderMusubi PanderMusubi added bug Something isn't working enhancement New feature or request docs bootstrap5 labels Nov 2, 2022
@PanderMusubi PanderMusubi requested a review from greyli November 2, 2022 11:57
@greyli greyli mentioned this pull request Nov 2, 2022
Merged
greyli
greyli requested changes Nov 2, 2022
View reviewed changes
@greyli
Copy link
Member

greyli commented Nov 2, 2022

Please update the title and comment to describe the PR.

@PanderMusubi
Copy link
Collaborator Author

PanderMusubi commented Nov 2, 2022

Please update the title and comment to describe the PR.

Done in #258

@PanderMusubi PanderMusubi changed the title bs522_icons191 Upgrading to Bootstrap and Bootswatch 5.2.2 and to Bootstrap Icons 1.9.1 Nov 2, 2022
@PanderMusubi PanderMusubi removed the bug Something isn't working label Nov 2, 2022
@PanderMusubi PanderMusubi requested a review from greyli November 2, 2022 15:56
@greyli
Copy link
Member

greyli commented Nov 7, 2022 •
edited
Loading

Please remove the change in setup.py, which is already included in #258.

Also, please update the changelog.

@PanderMusubi
Copy link
Collaborator Author

PanderMusubi commented Nov 7, 2022

Please remove the change in setup.py, which is already included in #258.

Also, please update the changelog.

done

@greyli
Copy link
Member

greyli commented Nov 11, 2022

Please update the changelog.

@PanderMusubi
Copy link
Collaborator Author

PanderMusubi commented Nov 11, 2022

Please update the changelog.

done

@greyli greyli merged commit 5e9da40 into helloflask:master Nov 13, 2022
@greyli
Copy link
Member

greyli commented Nov 13, 2022

Thanks!

@PanderMusubi PanderMusubi deleted the bs522_icons191 branch August 22, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greyli greyli greyli approved these changes

Assignees

No one assigned

Labels

bootstrap5 docs enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PanderMusubi @greyli