show links in table text #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@greyli I saw that table does not have tests yet for Bootstrap 5. Shall I make an issue for that? |
Collaborator
Author
|
@greyli can you review and hopefully merge this PR please? Thanks. |
Member
|
Thanks, I will review it this weekend. Please add docs for the newly added parameters. |
greyli
requested changes
May 17, 2022
greyli
requested changes
May 22, 2022
Member
greyli
left a comment
greyli
left a comment
There was a problem hiding this comment.
Looks good now. Could you add some unit tests and update the changelog?
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 1 1
Lines 134 134
Branches 23 23
=======================================
Hits 130 130
Misses 1 1
Partials 3 3 Continue to review full report at Codecov.
|
greyli
approved these changes
May 22, 2022
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review, fixes most important part of #118 which can be closed IMHO.
fixes #118