Globbing support in :open
#9723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
S-waiting-on-review
Contributor
|
Great functionality, testing here and works good! |
Contributor
Author
|
I added an upper limit of files to open with a glob and implemented ignoring directories when globbing. The PR is ready to be merged after a review 😃 |
Contributor
|
Currently this breaks opening non-existent file, e.g. |
Contributor
Author
|
@postsolar You are right. I will fix it in the next days. |
Contributor
Author
|
Fixed opening non-existent files and merge conflicts. |
pascalkuthe
reviewed
Apr 9, 2024
the-mikedavis
added
S-waiting-on-author
the-mikedavis
added
S-waiting-on-review
Contributor
Author
|
I was too focused on skipping non-relevant parents 😅 I just use the parallel |
Contributor
|
Your work is a prerequisite for a similar one that I have in mind which requires file globbing. Can I trouble you to factor out the code that retrieves matching paths, so I don't have to do it later on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5706
The functionality is almost done, but I would like to have feedback on how to improve the error handling.
Please tell me if you prefer moving the two inner functions to somewhere else.
Things to discuss:
Should I ignore directories when globbing? Currently, running something likeUpdate: I ignore directories when globbing now.:open *opens all files in the current directory and multiple file pickers for all directories in the current directory.