Use default clipboard provider for wezterm connect #10605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
how would this interact with tmux users on wezterm? I think they would still want to use the tmux provider? |
Author
|
@pascalkuthe I never use tmux in wezterm because that's suppose to be a replacement, but since you mentioned it, now I updated to code to prioritize tmux provider if it's used inside BeforeI've tested with current master, apparently copy to clipboard is not working for both wezterm & tmux inside
tmux in After
tmux inside Thank you! |
mpe
reviewed
Oct 24, 2024
|
|
||
| if env_var_is_set("WEZTERM_UNIX_SOCKET") && binary_exists("wezterm") { | ||
| Box::new(provider::FallbackProvider::new()) | ||
| if env_var_is_set("TMUX") && binary_exists("tmux") { |
There was a problem hiding this comment.
Can you refactor this so that the tmux check and provider definition is not duplicated (it already exists on line 146) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wezterm, they had their own method (wezterm connect) to run wezterm daemon on the remote that uses ssh as a channel
Because of that, default env such as
WAYLAND_DISPLAY&DISPLAYis still exist, so when we run helix through wezterm connect and yank selections to clipboard (<space>y) it doesn't do anything (somehow in my case helix will just hang? idk why)Therefore we need to check for
WEZTERM_UNIX_SOCKETbefore anything else, and just use fallback provider for that, so we can copy to clipboard even with wezterm connect 🎉Thanks!