Clear default propagator when one is explicitly added#8695
Merged
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
tomas-langer
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8651
The
propagationFormatsattribute of theJaegerTracerBuilderis anEnumSetand is assigned a single default value using a field initializer.But the
addPropagationFormatmethod simply adds its parameter to theEnumSetwithout regard to the default value.This PR adds logic to clear the default value upon the first explicit addition of a propagation format.
The PR includes tests to make sure the default value is cleared properly and retained properly.
Documentation
Bug fix; no doc impact.