4.x: Replace manual casts on pattern with instanceof in helidon/messaging modules .

Captain1653 · Captain1653 · commit 6f1a9e784d8a · 2024-09-06T08:12:07.000+03:00
diff --git a/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/JakartaCompletionListener.java b/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/JakartaCompletionListener.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021 Oracle and/or its affiliates.
+ * Copyright (c) 2021, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -35,8 +35,8 @@ public void onCompletion(Message message) {
     public void onException(Message message, Exception exception) {
         javax.jms.Message msg = ShimUtil.message(message);
 
-        if (exception instanceof JMSException) {
-            delegate.onException(msg, ShimUtil.exception((JMSException) exception));
+        if (exception instanceof JMSException jmsException) {
+            delegate.onException(msg, ShimUtil.exception(jmsException));
         } else {
             delegate.onException(msg, exception);
         }
diff --git a/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/JakartaJms.java b/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/JakartaJms.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, 2022 Oracle and/or its affiliates.
+ * Copyright (c) 2021, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -183,20 +183,20 @@ public static <T> T resolve(Object obj, Class<T> expectedType) {
      * @return shimmed jakarta namespace instance
      */
     public static Message create(javax.jms.Message delegate) {
-        if (delegate instanceof javax.jms.TextMessage) {
-            return create((javax.jms.TextMessage) delegate);
+        if (delegate instanceof javax.jms.TextMessage textMessage) {
+            return create(textMessage);
         }
-        if (delegate instanceof javax.jms.MapMessage) {
-            return create((javax.jms.MapMessage) delegate);
+        if (delegate instanceof javax.jms.MapMessage mapMessage) {
+            return create(mapMessage);
         }
-        if (delegate instanceof javax.jms.BytesMessage) {
-            return create((javax.jms.BytesMessage) delegate);
+        if (delegate instanceof javax.jms.BytesMessage bytesMessage) {
+            return create(bytesMessage);
         }
-        if (delegate instanceof javax.jms.StreamMessage) {
-            return create((javax.jms.StreamMessage) delegate);
+        if (delegate instanceof javax.jms.StreamMessage streamMessage) {
+            return create(streamMessage);
         }
-        if (delegate instanceof javax.jms.ObjectMessage) {
-            return create((javax.jms.ObjectMessage) delegate);
+        if (delegate instanceof javax.jms.ObjectMessage objectMessage) {
+            return create(objectMessage);
         }
         if (delegate == null) {
             return null;
diff --git a/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/JavaxCompletionListener.java b/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/JavaxCompletionListener.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021 Oracle and/or its affiliates.
+ * Copyright (c) 2021, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,8 +33,8 @@ public void onCompletion(Message message) {
 
     @Override
     public void onException(Message message, Exception exception) {
-        if (exception instanceof JMSException) {
-            delegate.onException(JakartaJms.create(message), ShimUtil.exception(((JMSException) exception)));
+        if (exception instanceof JMSException jmsException) {
+            delegate.onException(JakartaJms.create(message), ShimUtil.exception(jmsException));
         } else {
             delegate.onException(JakartaJms.create(message), exception);
         }
diff --git a/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/ShimUtil.java b/messaging/connectors/jms-shim/src/main/java/io/helidon/messaging/connectors/jms/shim/ShimUtil.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021 Oracle and/or its affiliates.
+ * Copyright (c) 2021, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -78,29 +78,29 @@ static javax.jms.JMSException exception(JMSException source) {
     }
 
     static javax.jms.Destination destination(Destination destination) {
-        if (destination instanceof JakartaDestination) {
-            return ((JakartaDestination) destination).unwrap();
+        if (destination instanceof JakartaDestination jakartaDestination) {
+            return jakartaDestination.unwrap();
         }
-        if (destination instanceof javax.jms.Destination) {
-            return (javax.jms.Destination) destination;
+        if (destination instanceof javax.jms.Destination javaxDestination) {
+            return javaxDestination;
         }
         throw new RuntimeException("Destination was not created correctly, cannot convert to javax.jms.Destination: "
                                            + destination);
     }
 
     static Topic topic(jakarta.jms.Topic topic) {
-        if (topic instanceof JakartaTopic) {
-            return ((JakartaTopic) topic).unwrap();
+        if (topic instanceof JakartaTopic jakartaTopic) {
+            return jakartaTopic.unwrap();
         }
-        if (topic instanceof javax.jms.Topic) {
-            return (javax.jms.Topic) topic;
+        if (topic instanceof javax.jms.Topic javaxTopic) {
+            return javaxTopic;
         }
         throw new RuntimeException("Topic was not created correctly, cannot convert to javax.jms.Topic: " + topic);
     }
 
     static Queue queue(jakarta.jms.Queue queue) {
-        if (queue instanceof JakartaQueue) {
-            return ((JakartaQueue) queue).unwrap();
+        if (queue instanceof JakartaQueue jakartaQueue) {
+            return jakartaQueue.unwrap();
         }
         if (queue instanceof javax.jms.Topic) {
             return (javax.jms.Queue) queue;
@@ -109,11 +109,11 @@ static Queue queue(jakarta.jms.Queue queue) {
     }
 
     static javax.jms.Message message(Message message) {
-        if (message instanceof JakartaMessage) {
-            return ((JakartaMessage) message).unwrap();
+        if (message instanceof JakartaMessage jakartaMessage) {
+            return jakartaMessage.unwrap();
         }
-        if (message instanceof javax.jms.Message) {
-            return (javax.jms.Message) message;
+        if (message instanceof javax.jms.Message javaxMessage) {
+            return javaxMessage;
         }
         throw new RuntimeException("Message was not created correctly, cannot convert to javax.jms.Message: " + message);
     }
diff --git a/messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConnector.java b/messaging/connectors/jms/src/main/java/io/helidon/messaging/connectors/jms/JmsConnector.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, 2023 Oracle and/or its affiliates.
+ * Copyright (c) 2020, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -424,10 +424,10 @@ protected JmsMessage<?> createMessage(NackHandler nackHandler,
                                           jakarta.jms.Message message,
                                           Executor executor,
                                           SessionMetadata sessionMetadata) {
-        if (message instanceof TextMessage) {
-            return new JmsTextMessage(nackHandler, (TextMessage) message, executor, sessionMetadata);
-        } else if (message instanceof BytesMessage) {
-            return new JmsBytesMessage(nackHandler, (BytesMessage) message, executor, sessionMetadata);
+        if (message instanceof TextMessage textMessage) {
+            return new JmsTextMessage(nackHandler, textMessage, executor, sessionMetadata);
+        } else if (message instanceof BytesMessage bytesMessage) {
+            return new JmsBytesMessage(nackHandler, bytesMessage, executor, sessionMetadata);
         } else {
             return new AbstractJmsMessage<jakarta.jms.Message>(nackHandler, executor, sessionMetadata) {
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright (c) 2021 Oracle and/or its affiliates.`
	`2`	`+ * Copyright (c) 2021, 2024 Oracle and/or its affiliates.`
`3`	`3`	`*`
`4`	`4`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`5`	`5`	`* you may not use this file except in compliance with the License.`
`@@ -78,29 +78,29 @@ static javax.jms.JMSException exception(JMSException source) {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`static javax.jms.Destination destination(Destination destination) {`
`81`		`- if (destination instanceof JakartaDestination) {`
`82`		`- return ((JakartaDestination) destination).unwrap();`
	`81`	`+ if (destination instanceof JakartaDestination jakartaDestination) {`
	`82`	`+ return jakartaDestination.unwrap();`
`83`	`83`	`}`
`84`		`- if (destination instanceof javax.jms.Destination) {`
`85`		`- return (javax.jms.Destination) destination;`
	`84`	`+ if (destination instanceof javax.jms.Destination javaxDestination) {`
	`85`	`+ return javaxDestination;`
`86`	`86`	`}`
`87`	`87`	`throw new RuntimeException("Destination was not created correctly, cannot convert to javax.jms.Destination: "`
`88`	`88`	`+ destination);`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`static Topic topic(jakarta.jms.Topic topic) {`
`92`		`- if (topic instanceof JakartaTopic) {`
`93`		`- return ((JakartaTopic) topic).unwrap();`
	`92`	`+ if (topic instanceof JakartaTopic jakartaTopic) {`
	`93`	`+ return jakartaTopic.unwrap();`
`94`	`94`	`}`
`95`		`- if (topic instanceof javax.jms.Topic) {`
`96`		`- return (javax.jms.Topic) topic;`
	`95`	`+ if (topic instanceof javax.jms.Topic javaxTopic) {`
	`96`	`+ return javaxTopic;`
`97`	`97`	`}`
`98`	`98`	`throw new RuntimeException("Topic was not created correctly, cannot convert to javax.jms.Topic: " + topic);`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`static Queue queue(jakarta.jms.Queue queue) {`
`102`		`- if (queue instanceof JakartaQueue) {`
`103`		`- return ((JakartaQueue) queue).unwrap();`
	`102`	`+ if (queue instanceof JakartaQueue jakartaQueue) {`
	`103`	`+ return jakartaQueue.unwrap();`
`104`	`104`	`}`
`105`	`105`	`if (queue instanceof javax.jms.Topic) {`
`106`	`106`	`return (javax.jms.Queue) queue;`
`@@ -109,11 +109,11 @@ static Queue queue(jakarta.jms.Queue queue) {`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`static javax.jms.Message message(Message message) {`
`112`		`- if (message instanceof JakartaMessage) {`
`113`		`- return ((JakartaMessage) message).unwrap();`
	`112`	`+ if (message instanceof JakartaMessage jakartaMessage) {`
	`113`	`+ return jakartaMessage.unwrap();`
`114`	`114`	`}`
`115`		`- if (message instanceof javax.jms.Message) {`
`116`		`- return (javax.jms.Message) message;`
	`115`	`+ if (message instanceof javax.jms.Message javaxMessage) {`
	`116`	`+ return javaxMessage;`
`117`	`117`	`}`
`118`	`118`	`throw new RuntimeException("Message was not created correctly, cannot convert to javax.jms.Message: " + message);`
`119`	`119`	`}`