Skip to content

Conversation

@m-Bilal
Copy link
Member

@m-Bilal m-Bilal commented Jul 14, 2025

No description provided.

@m-Bilal m-Bilal requested a review from Copilot July 14, 2025 20:21

This comment was marked as outdated.

@m-Bilal m-Bilal requested a review from Copilot July 14, 2025 20:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the hardcoded SDK version lookup with a dynamic fetch that respects user npm configurations, adds error handling, and updates documentation.

  • Use pacote’s where option to honor .npmrc and other npm settings when fetching the latest SDK version.
  • Remove the hardcoded default SDK version and its getter from context.ts.
  • Simplify imports and introduce fatal logging with process exit on failure.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/app/writer/package-json-writer.ts Added where option for npm config resolution, removed fallback method, updated error handling
src/app/context.ts Removed NDC_NODEJS_LAMBDA_SDK_VERSION constant and its getter method
changelog.md Noted support for .npmrc in Unreleased section
Comments suppressed due to low confidence (2)

src/app/writer/package-json-writer.ts:86

  • The new getLatestNdcNodeJsLambdaSdkVersion function introduces network calls and error handling changes that aren't covered by existing tests; consider adding unit tests for both successful fetch and failure scenarios.
async function getLatestNdcNodeJsLambdaSdkVersion(): Promise<SemVer> {

src/app/writer/package-json-writer.ts:99

  • [nitpick] Calling process.exit directly makes this function hard to test and may prevent proper cleanup; consider throwing an error and letting the caller decide how to handle termination.
    exit(1);

@m-Bilal m-Bilal merged commit 8105feb into main Jul 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant