Skip to content

Conversation

@SURTBLAZE
Copy link

This ensures Hasura correctly handles "No Content" responses without attempting JSON parsing.

Impact on existing features

No breaking changes.
No changes to golden files , code generation output is structurally identical.

Related Issue

Fixes: hasura/graphql-engine#10792

Questions

  1. Do you prefer leaving the existing golden tests as are, or should I update / extend golden tests to explicitly assert 204 handling in the HTTP client layer?
  2. After merging this fix, I plan to add runtime tests to the main Hasura project (graphql-engine) to ensure correct behavior end-to-end when calling REST APIs that return 204 No Content. Please confirm that this is the preferred place for such tests (as opposed to keeping runtime tests in ndc-open-api-lambda).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

204 status code from API caused Unexpected end of JSON input error.

1 participant