This repository was archived by the owner on Jan 8, 2024. It is now read-only.
update ecr-pull to support doing entrypoint injection #4847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgovern-apixio
force-pushed
the
ecr-pull
branch
from
827cf26 to
3073a71
Compare
Ran `make gen/integrations-hcl` and `make gen/website-mdx`
izaaklauer
suggested changes
Jul 19, 2023
Contributor
izaaklauer
left a comment
izaaklauer
left a comment
There was a problem hiding this comment.
Nice improvement! Your approach of invoking the docker pull builder from ecr is clever, and makes sense to me.
I requested one small change, and reran our documentation automation and made a PR to your branch here: https://github.com/kmcgovern-apixio/waypoint/pull/1/files. Once those are in, we can merge this.
Comment on lines
+1
to
+2
| // Copyright (c) HashiCorp, Inc. | ||
| // SPDX-License-Identifier: MPL-2.0 |
Contributor
There was a problem hiding this comment.
Not sure why these are in this PR, but it's ok!
Contributor
Author
There was a problem hiding this comment.
originally i had changes to the ecr protobuf but ended up not needing that. this is just a remnant from that!
Co-authored-by: Izaak Lauer <[email protected]>
Docs and changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so ecr-pull can be used the same way docker-pull can to inject the waypoint entrypoint. Currently this is non-passive because it keeps the same default as
docker-pullwhich will inject the entrypoint. disabling the entrypoint injection keeps the previous behavior and does not require the docker or kankio builder (as before)