This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Set reasonable defaults for ECS plugin health check timeout #4767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladin-devops
added
plugin/ecs
ecosystem
Prior to this commit, depending on the type of health check configured, the default timeout could have been set to be longer than the default interval, which is not a valid setting in AWS. This commit sets the default timeout to be lower than the interval.
paladin-devops
force-pushed
the
b-ecs-health-check-defaults
branch
from
31a82e1 to
cad0b21
Compare
catsby
approved these changes
Jun 5, 2023
Contributor
catsby
left a comment
catsby
left a comment
There was a problem hiding this comment.
LGTM just a question over if we should check the values prior to sending to AWS
briancain
approved these changes
Jun 5, 2023
paladin-devops
force-pushed
the
b-ecs-health-check-defaults
branch
from
8286f40 to
8183f99
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, depending on the type of health check configured, the default timeout could have been set to be longer than the default interval (the defaults are set differently by AWS depending on how you configure the health check protocol), which is not a valid setting in AWS. This PR sets the default timeout to be lower than the interval - 5 second timeout and 30 second interval.