This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Azure Plugin auth fix #4763
Merged
Azure Plugin auth fix #4763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
approved these changes
Jun 2, 2023
Contributor
briancain
left a comment
briancain
left a comment
There was a problem hiding this comment.
Looks like this should resolve the issue 👍🏻
…I auth before error.
paladin-devops
force-pushed
the
2589-azure-auth
branch
from
a84372b to
fbb5d20
Compare
Contributor
Author
|
An Azure plugin user tested this out and the fix is working! Will merge when checks pass. |
evanphx
approved these changes
Jun 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Azure ACI plugin to attempt CLI auth before erroring, rather than erroring if environment auth failed. Closes #2589.