This repository was archived by the owner on Jan 8, 2024. It is now read-only.
fix(builtin): de-dupe various hcl annotation keys #4701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Greg Hoin <[email protected]>
jgwhite
force-pushed
the
tob-26-duplicate-annotation-keys
branch
from
c9d4c49 to
0425c4a
Compare
Merged
evanphx
approved these changes
May 12, 2023
Contributor
evanphx
left a comment
evanphx
left a comment
There was a problem hiding this comment.
Makes me think we need to build a little hclvet tool that will detect this for us in CI!
Contributor
|
Oh lololol my comment is what #4702 does! AMAZING!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.