-
Notifications
You must be signed in to change notification settings - Fork 329
Additional install flags for Nomad service address and network mode #4619
Conversation
-nomad-service-address
populates group{service{address=}}
for each of the waypoint-server services
https://developer.hashicorp.com/nomad/docs/job-specification/service#address
-nomad-network-mode
populates group{network{mode=}}
https://developer.hashicorp.com/nomad/docs/job-specification/network#network-modes
and fills in task{config{network_mode=}}
as appropriate
|
@gulducat thanks so much for doing this! Could you add a changelog entry as well? You can copy one of the ones in |
|
@gulducat This looks great, Tested this out and nomad is giving the cli back the address given for the services! Do you mind if I push up the docs related changes for this change to the PR to make tests happy? (You can also do this by running |
|
Thanks folks! I added a changelog entry and what I think is the relevant subset of P.S. FYI gosh the full changeset that gen/website produces is quite a lot! also I didn't realize at first that it had succeeded well-enough, because the |
|
There may be something missing for other parts of the website, but what you generated and committed was all that we needed! This all looks good from my point of view now Thanks |
add new flags from #4619 to upgrade command
The overall goal here is to
waypoint installinto a Nomad node from the outside. In my case, a Vagrant machine from my laptop, but also should work with other cases like cloud vendors where thewaypoint-serverservice needs to be given a public IP, to which the install procedure connects after job submission.For example, using a
meta.public_ipthat I set manually in my Nomad client config:Of course
-nomad-service-address=192.168.56.200would have worked just as well, but the meta is for demonstration, as I imagine that on AWS one might use'${attr.unique.platform.aws.public-ipv4}'to set the service address dynamically.The ~publicly-routable IP at the bottom of the install output (and used during install) comes from the Nomad services:
I do wonder though if perhaps separate service(s) could/should be made for this connection during install, vs internal waypoint->waypoint communication? Do the runner(s) connect to waypoint-server using this service? I didn't look that far into this part.