This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Add CORS options to lambda-function-url releaser #4418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This doesn’t seem to update the function URL CORS config at the moment. More investigation needed. |
jgwhite
changed the title
jgwhite
force-pushed
the
lambda-function-url-cors
branch
from
b104668 to
6370e5c
Compare
Contributor
Author
|
Bit further, but curious behavior when no |
Contributor
I think that usually means the Waypoint server panicked. If you haven't checked already, you'll find what happened in the server logs I think! |
jgwhite
force-pushed
the
lambda-function-url-cors
branch
from
6370e5c to
b1eec68
Compare
jgwhite
added a commit
that referenced
this pull request
Jan 24, 2023
Contributor
Author
|
This is now working nicely, but the docs need some love. |
Addresses #4233 Co-authored-by: Shirley Xiaolin Xu <[email protected]> Co-authored-by: Britt Gresham <[email protected]> Co-authored-by: Brian Cain <[email protected]>
jgwhite
added a commit
that referenced
this pull request
Jan 24, 2023
jgwhite
force-pushed
the
lambda-function-url-cors
branch
from
5514406 to
0366df0
Compare
jgwhite
force-pushed
the
lambda-function-url-cors
branch
from
0366df0 to
c7e9d7a
Compare
demophoon
approved these changes
Jan 24, 2023
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the change?
Addresses #4233
What’s the plan?
What does it look like?
cors-fast.mov
How do I test it?
Try adding CORS config to one of the Lambda examples.
Visit the website preview and verify the docs make sense.