Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

UX: Combine git datasource ref information into single message#4115

Merged
briancain merged 3 commits into
mainfrom
maint/ux/combine-git-ref-data
Oct 26, 2022
Merged

UX: Combine git datasource ref information into single message#4115
briancain merged 3 commits into
mainfrom
maint/ux/combine-git-ref-data

Conversation

@briancain

@briancain briancain commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Prior to this commit, we were split outputting git data source information within a jobstream. With this fix, we now output the git information in a single place, and when we go to read the jobstream we simply log the information at DEBUG.

Fixes #4097

@briancain
UX: Combine git datasource ref information into single message
f6e0169 
Prior to this commit, we were split outputting git data source
information within a jobstream. With this fix, we now output the git
information in a single place, and when we go to read the jobstream we
simply log the information at DEBUG.

Fixes #4097
@briancain briancain added pr/no-changelog No automatic changelog entry required for this pull request backport/0.10.x labels Oct 26, 2022
@briancain briancain requested review from a team, demophoon and paladin-devops October 26, 2022 17:45
@github-actions github-actions Bot added the core label Oct 26, 2022
@briancain briancain removed the pr/no-changelog No automatic changelog entry required for this pull request label Oct 26, 2022
@briancain

briancain commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author 
brian@ubuntu:waypoint-tetris λ waypoint up                                                                                                                 ±[main]
  Performing operation on "kubernetes" with runner profile "01GGAQ2KFB3G60R8GTAVFCWFM8"

» Cloning data from Git
         URL: https://github.com/briancain/waypoint-tetris.git
  Git Commit: 5ede1b60b4378abc72c391a1a923e39ce23c91a2
   Timestamp: 2022-10-26 15:46:36 +0000 UTC
     Message: Fix workspace release

...
...

jgwhite
jgwhite approved these changes Oct 26, 2022
View reviewed changes

@jgwhite jgwhite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@briancain briancain merged commit 47a326d into main Oct 26, 2022
@briancain briancain deleted the maint/ux/combine-git-ref-data branch October 26, 2022 20:18
@hc-github-team-waypoint hc-github-team-waypoint mentioned this pull request Oct 26, 2022
Merged
@jgwhite

jgwhite commented Oct 31, 2022

Copy link
Copy Markdown
Contributor

Looks like the Auth: ssh line emitted by GitSource.auth isn’t playing along with the nice alignment. Not a big deal; something fun to fix at some point down the road.

CleanShot 2022-10-31 at 23 21 07@2x

@briancain

briancain commented Oct 31, 2022

Copy link
Copy Markdown
Contributor Author

I gotchu @jgwhite - #4144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@demophoon demophoon Awaiting requested review from demophoon
@paladin-devops paladin-devops Awaiting requested review from paladin-devops
2 more reviewers
@evanphx evanphx evanphx approved these changes
@jgwhite jgwhite jgwhite approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/0.10.x core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UX: Combine git terminal event messages

3 participants

@briancain @jgwhite @evanphx