This repository was archived by the owner on Jan 8, 2024. It is now read-only.
cli: Fix panic when no flag specified for waypoint runner profile set
#4013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if you ran the profile set command without any flags, the command would panic due to the flagPluginType being a string pointer. This commit fixes that by instead moving it back to a simple String flag with a emptry string default. It preserves the behavior where if not specified, the CLI will attempt to use the existing plugin type rather than setting it to empty string. Fixes #4012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if you ran the profile set command without any flags, the command would panic due to the flagPluginType being a string pointer. This commit fixes that by instead moving it back to a simple String flag with a emptry string default. It preserves the behavior where if not specified, the CLI will attempt to use the existing plugin type rather than setting it to empty string.
Fixes #4012