This repository was archived by the owner on Jan 8, 2024. It is now read-only.
bolt: Cancel WatchJob for TaskCancel #3893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates TaskCancel to also cancel the WatchTask job if it exists. Not all task launcher plugins implement WatchTask so there's an extra check that the job ref was set prior to cancellation.
briancain
added
the
pr/no-changelog
briancain
removed
the
pr/no-changelog
izaaklauer
approved these changes
Sep 16, 2022
paladin-devops
approved these changes
Sep 16, 2022
Contributor
paladin-devops
left a comment
paladin-devops
left a comment
There was a problem hiding this comment.
❌ Code looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates TaskCancel to also cancel the WatchTask job if it exists. Not all task launcher plugins implement WatchTask so there's an extra check that the job ref was set prior to cancellation.