This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Nomad Plugin bug fixes #3883
Merged
Nomad Plugin bug fixes #3883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paladin-devops
commented
Sep 15, 2022
paladin-devops
commented
- Fixed a bug in the jobspec status check where a deployment that had canary allocs would always report as partially healthy, even if it was healthy
- Fixed the Nomad task launcher plugin to deploy the Nomad ODRs to the region and namespace specified in the runner profile plugin config
Update the Nomad task launcher plugin to respect the namespace and region parameters in the ODR config.
The Noamd jobspec platform plugin status check would incorrectly report a deployment as partially healthy, if the Nomad job had canary allocations. It is possible for such a deployment to be partially healthy; however canary allocations end up in the "complete" state when the deployment is promoted. Therefore, after using the "release" lifecycle with the canary plugin, the # of "complete" allocs would be > 0, and thusly cause a partially healthy state, regardless of the fact that the app is indeed healthy, and its deployment was just promoted, killing the canaries.
paladin-devops
added
plugin/nomad-jobspec
ecosystem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.