Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

ui: limit number of deployments requested#2930

Merged
jgwhite merged 1 commit into
mainfrom
ui/deployments-limit
Jan 24, 2022
Merged

ui: limit number of deployments requested#2930
jgwhite merged 1 commit into
mainfrom
ui/deployments-limit

Conversation

@jgwhite

@jgwhite jgwhite commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Why the change?

Closes #2919

What’s the plan?

  • Set limit on OperationOrder in UI_ListDeployments request
  • Document the results in this PR

What does it look like?

Before

~10s for ~50 deployments

CleanShot 2022-01-21 at 13 17 21@2x

After

~2s for the latest 10 of ~50 deployments (still pretty slow, but tolerable)

CleanShot 2022-01-21 at 13 17 42@2x

How do I test it?

  1. Generate lots of deployments on a Waypoint server of your choosing
  2. git checkout ui/deployments-limit
  3. cd ui && yarn start local
  4. Visit http://localhost:4200
  5. Navigate to the app in question
  6. Verify that the loading time is tolerable

@jgwhite jgwhite added this to the 0.7.x milestone Jan 21, 2022
@jgwhite jgwhite self-assigned this Jan 21, 2022
@github-actions

Copy link
Copy Markdown

Ember Asset Size action

As of caf6830

Files that got Bigger 🚨:

File raw gzip
waypoint.js +15 B +4 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B
waypoint.css 0 B 0 B

@jgwhite jgwhite marked this pull request as ready for review January 21, 2022 12:21
@jgwhite jgwhite requested a review from a team January 21, 2022 12:21

@briancain briancain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not frontend, but this change makes sense to me as a temporary workaround until we can fix that slow query 🙏🏻

@sabrinako sabrinako left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looked good but just wanted to test on local first, definitely a shorter load time but do agree we need to do some more improvements to this endpoint's performance in the future

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: Limit number of deployments requested

3 participants