This repository was archived by the owner on Jan 8, 2024. It is now read-only.
ui: limit number of deployments requested#2930
Merged
Merged
Conversation
Ember Asset Size actionAs of caf6830 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
briancain
approved these changes
Jan 21, 2022
briancain
left a comment
Contributor
There was a problem hiding this comment.
I am not frontend, but this change makes sense to me as a temporary workaround until we can fix that slow query 🙏🏻
sabrinako
approved these changes
Jan 21, 2022
sabrinako
left a comment
Contributor
There was a problem hiding this comment.
Code looked good but just wanted to test on local first, definitely a shorter load time but do agree we need to do some more improvements to this endpoint's performance in the future
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change?
Closes #2919
What’s the plan?
limitonOperationOrderinUI_ListDeploymentsrequestWhat does it look like?
Before
~10s for ~50 deployments
After
~2s for the latest 10 of ~50 deployments (still pretty slow, but tolerable)
How do I test it?
git checkout ui/deployments-limitcd ui && yarn start local