Merge pull request #4120 from hashicorp/backport/maint/cli/complete-time-fix-pipelines/gratefully-flying-pig

hc-github-team-waypoint · web-flow · commit cd8bdef3e698 · 2022-10-26T16:23:16.000-04:00
This pull request was automerged via backport-assistant
diff --git a/.changelog/4113.txt b/.changelog/4113.txt
@@ -0,0 +1,4 @@
+```release-note:bug
+cli: Only show "CompleteTime" on `waypoint pipeline list` if the job has a valid
+complete time.
+```
diff --git a/internal/cli/pipeline_list.go b/internal/cli/pipeline_list.go
@@ -131,7 +131,9 @@ func (c *PipelineListCommand) Run(args []string) int {
 				return 1
 			}
 
-			lastRunEnd = humanize.Time(j.CompleteTime.AsTime())
+			if j.CompleteTime != nil {
+				lastRunEnd = humanize.Time(j.CompleteTime.AsTime())
+			}
 			state = strings.ToLower(lastRun.State.String())
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,9 @@ func (c *PipelineListCommand) Run(args []string) int {`
`131`	`131`	`return 1`
`132`	`132`	`}`
`133`	`133`
`134`		`- lastRunEnd = humanize.Time(j.CompleteTime.AsTime())`
	`134`	`+ if j.CompleteTime != nil {`
	`135`	`+ lastRunEnd = humanize.Time(j.CompleteTime.AsTime())`
	`136`	`+ }`
`135`	`137`	`state = strings.ToLower(lastRun.State.String())`
`136`	`138`	`}`
`137`	`139`