Skip to content

Conversation

@mladlow
Copy link
Collaborator

@mladlow mladlow commented Aug 20, 2020

The upgrading pages look like:
Screen Shot 2020-08-20 at 15 39 38

@calvn
Copy link
Contributor

calvn commented Aug 20, 2020

Should the upgrades be for 1.5.2, 1.4.5, 1.3.8, and 1.2.5 now?

@mladlow mladlow requested a review from calvn August 20, 2020 21:20
@mladlow
Copy link
Collaborator Author

mladlow commented Aug 20, 2020

In the past we've kept the known issues on the version with the known issues, but I've added a note to recommend against using the versions with known issues.

Copy link
Contributor

@pbernal pbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mladlow mladlow merged commit 2482d4c into master Aug 20, 2020
@mladlow mladlow deleted the oss-binaries-ui branch August 20, 2020 22:57
mladlow added a commit that referenced this pull request Aug 20, 2020
* Updates for 1.5.1, 1.4.4, 1.3.8, and 1.2.5

* Recommend against using these versions

* Re-running checks

* Update docs-navigation.js
pull bot pushed a commit to sigtrap/vault that referenced this pull request Oct 2, 2025
…rp#9755) (hashicorp#9793)

* fix broken form after ember data migration

* convert to typescript, add tests

* only transition on success

* use test.each

* use AuthMethodResource

* add tests and refactor fallback for engine-display-data

* fix token_type submitting for token auth methods

* fix imports

* fix conditional for token_type

* update comments add check for token_type

* fix test and add comment to clarify different setting types

* revert and keep unknown type, blowing the scope out too much!

Co-authored-by: claire bontempo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants