From 4c990d125be7bba5843a341b5016adc27a1c2d3b Mon Sep 17 00:00:00 2001 From: Angel Garbarino Date: Thu, 2 May 2024 12:08:01 -0600 Subject: [PATCH 1/5] replace transitionTo with router.refresh --- ui/lib/sync/addon/components/secrets/page/overview.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/lib/sync/addon/components/secrets/page/overview.ts b/ui/lib/sync/addon/components/secrets/page/overview.ts index 187c7b59e99..4dd50ef8b27 100644 --- a/ui/lib/sync/addon/components/secrets/page/overview.ts +++ b/ui/lib/sync/addon/components/secrets/page/overview.ts @@ -44,6 +44,7 @@ export default class SyncSecretsDestinationsPageComponent extends Component Date: Thu, 2 May 2024 12:08:26 -0600 Subject: [PATCH 2/5] cleanup --- ui/lib/sync/addon/components/secrets/page/overview.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/lib/sync/addon/components/secrets/page/overview.ts b/ui/lib/sync/addon/components/secrets/page/overview.ts index 4dd50ef8b27..9b9723d0eda 100644 --- a/ui/lib/sync/addon/components/secrets/page/overview.ts +++ b/ui/lib/sync/addon/components/secrets/page/overview.ts @@ -44,7 +44,6 @@ export default class SyncSecretsDestinationsPageComponent extends Component Date: Thu, 2 May 2024 12:21:56 -0600 Subject: [PATCH 3/5] changelog --- changelog/26790.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelog/26790.txt diff --git a/changelog/26790.txt b/changelog/26790.txt new file mode 100644 index 00000000000..593d2de67d9 --- /dev/null +++ b/changelog/26790.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: Refresh model within a namespace on the Secrets Sync overview page. +``` \ No newline at end of file From bccec6a26781cf01f82991d03350804a9ba38a94 Mon Sep 17 00:00:00 2001 From: Angel Garbarino Date: Thu, 2 May 2024 12:35:37 -0600 Subject: [PATCH 4/5] nice test catch --- ui/tests/acceptance/sync/secrets/overview-test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/tests/acceptance/sync/secrets/overview-test.js b/ui/tests/acceptance/sync/secrets/overview-test.js index 79dfa6d7279..4d2c8bc16ff 100644 --- a/ui/tests/acceptance/sync/secrets/overview-test.js +++ b/ui/tests/acceptance/sync/secrets/overview-test.js @@ -148,8 +148,8 @@ module('Acceptance | sync | overview', function (hooks) { }); test('it should make activation-flag requests to correct namespace', async function (assert) { - assert.expect(3); - + assert.expect(4); + // should call GET activation-flags twice because it the component needs an updated response after confirming to see if the feature has been activated this.server.get('/sys/activation-flags', (_, req) => { assert.deepEqual(req.requestHeaders, {}, 'Request is unauthenticated and in root namespace'); return { From 79b7f430b06052c8362e05cb811bb17355973c27 Mon Sep 17 00:00:00 2001 From: Angel Garbarino Date: Thu, 2 May 2024 12:37:15 -0600 Subject: [PATCH 5/5] words are hard --- ui/tests/acceptance/sync/secrets/overview-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/tests/acceptance/sync/secrets/overview-test.js b/ui/tests/acceptance/sync/secrets/overview-test.js index 4d2c8bc16ff..0f49d6838ea 100644 --- a/ui/tests/acceptance/sync/secrets/overview-test.js +++ b/ui/tests/acceptance/sync/secrets/overview-test.js @@ -149,7 +149,7 @@ module('Acceptance | sync | overview', function (hooks) { test('it should make activation-flag requests to correct namespace', async function (assert) { assert.expect(4); - // should call GET activation-flags twice because it the component needs an updated response after confirming to see if the feature has been activated + // should call GET activation-flags twice because we need an updated response after activating the feature this.server.get('/sys/activation-flags', (_, req) => { assert.deepEqual(req.requestHeaders, {}, 'Request is unauthenticated and in root namespace'); return {