new resource `azurerm_kubernetes_cluster_deployment_safeguard` by ms-henglu · Pull Request #31670 · hashicorp/terraform-provider-azurerm

ms-henglu · 2026-02-04T05:29:27Z

fixes #30484

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

liuwuliuyun

A small comment, otherwise LGTM~

liuwuliuyun · 2026-02-06T07:25:14Z

+
+---
+
+* `excluded_namespaces` - (Optional) A set of Kubernetes namespace names that should be excluded from Deployment Safeguards enforcement. This allows certain namespaces to bypass the configured policies.


I think we implemented this property as list, so this should be excluded_namespaces - (Optional) A list of Kubernetes namespace names...

ms-zhenhua · 2026-02-09T07:32:16Z

+)
+
+var (
+	_ sdk.Resource           = KubernetesClusterDeploymentSafeguardResource{}


_ sdk.Resource = ... can be removed as it's part of ResourceWithUpdate

ms-zhenhua · 2026-02-09T07:39:29Z

+provider "azurerm" {
+  features {}
+}


the provider block should be set in each testcase like basic, complete, etc.

ms-zhenhua · 2026-02-09T07:40:39Z

+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0


Suggested change

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

// Copyright IBM Corp. 2014, 2025

// SPDX-License-Identifier: MPL-2.0

ms-zhenhua · 2026-02-09T07:40:53Z

+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0


Suggested change

// Copyright (c) HashiCorp, Inc.

// SPDX-License-Identifier: MPL-2.0

// Copyright IBM Corp. 2014, 2025

// SPDX-License-Identifier: MPL-2.0

ms-zhenhua · 2026-02-09T08:48:35Z

+
+type KubernetesClusterDeploymentSafeguardResource struct{}
+
+func TestAccKubernetesClusterDeploymentSafeguards_basic(t *testing.T) {


Suggested change

func TestAccKubernetesClusterDeploymentSafeguards_basic(t *testing.T) {

func TestAccKubernetesClusterDeploymentSafeguard_basic(t *testing.T) {

ms-zhenhua · 2026-02-09T08:48:45Z

+	})
+}
+
+func TestAccKubernetesClusterDeploymentSafeguards_requiresImport(t *testing.T) {


Suggested change

func TestAccKubernetesClusterDeploymentSafeguards_requiresImport(t *testing.T) {

func TestAccKubernetesClusterDeploymentSafeguard_requiresImport(t *testing.T) {

ms-zhenhua · 2026-02-09T08:48:53Z

+	})
+}
+
+func TestAccKubernetesClusterDeploymentSafeguards_complete(t *testing.T) {


Suggested change

func TestAccKubernetesClusterDeploymentSafeguards_complete(t *testing.T) {

func TestAccKubernetesClusterDeploymentSafeguard_complete(t *testing.T) {

ms-zhenhua · 2026-02-09T08:49:01Z

+	})
+}
+
+func TestAccKubernetesClusterDeploymentSafeguards_update(t *testing.T) {


Suggested change

func TestAccKubernetesClusterDeploymentSafeguards_update(t *testing.T) {

func TestAccKubernetesClusterDeploymentSafeguard_update(t *testing.T) {

liuwuliuyun

LGTM, Thanks

ms-zhenhua

Thanks for the updates. LGTM~

sreallymatt

Thanks @ms-henglu - just a few minor comments

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>

sreallymatt

Thanks @ms-henglu - LGTM ✅

github-actions · 2026-04-27T02:43:18Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ms-henglu requested review from a team, WodansSon and magodo as code owners February 4, 2026 05:29

github-actions Bot added documentation dependencies size/XL waiting-response and removed waiting-response labels Feb 4, 2026

ms-henglu added the ai-assisted label Feb 4, 2026

github-actions Bot removed the waiting-response label Feb 4, 2026

liuwuliuyun reviewed Feb 6, 2026

View reviewed changes

github-actions Bot added waiting-response and removed waiting-response labels Feb 6, 2026

ms-zhenhua suggested changes Feb 9, 2026

View reviewed changes

github-actions Bot assigned ms-zhenhua Feb 9, 2026

github-actions Bot added the waiting-response label Feb 9, 2026

rcskosir added the new-resource label Feb 9, 2026

github-actions Bot removed the waiting-response label Feb 10, 2026

ms-henglu requested review from liuwuliuyun and ms-zhenhua February 10, 2026 07:55

liuwuliuyun approved these changes Feb 14, 2026

View reviewed changes

ms-zhenhua approved these changes Feb 25, 2026

View reviewed changes

ms-henglu added 6 commits March 6, 2026 02:12

go mod vendor

9a76906

new resource azurerm_kubernetes_cluster_deployment_safeguard

19b699e

make document-fix

1351bba

make generate

3400d59

update docs

875973b

resolve comments

c6eb720

ms-henglu force-pushed the branch-260204-aks-safe-deployment-guard branch from dae8916 to c6eb720 Compare March 6, 2026 02:13

github-actions Bot added the waiting-response label Mar 6, 2026

re-trigger CI

4f34044

github-actions Bot added waiting-response and removed waiting-response labels Mar 6, 2026

go mod tidy & vendor

3f871bb

github-actions Bot removed the waiting-response label Mar 6, 2026

Merge branch 'main' into branch-260204-aks-safe-deployment-guard

be04925

mybayern1974 unassigned ms-zhenhua Mar 19, 2026

sreallymatt requested changes Mar 20, 2026

View reviewed changes

github-actions Bot assigned sreallymatt Mar 20, 2026

github-actions Bot added the waiting-response label Mar 20, 2026

Apply suggestions from code review

bf9b946

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>

github-actions Bot added waiting-response and removed waiting-response labels Mar 23, 2026

STYLE: fix gofmt formatting in deployment safeguard resource

e7d2dff

github-actions Bot removed the waiting-response label Mar 26, 2026

sreallymatt approved these changes Mar 27, 2026

View reviewed changes

sreallymatt merged commit 5a49cda into hashicorp:main Mar 27, 2026
35 checks passed

github-actions Bot added this to the v4.67.0 milestone Mar 27, 2026

github-actions Bot locked as resolved and limited conversation to collaborators Apr 27, 2026


		---

		* `excluded_namespaces` - (Optional) A set of Kubernetes namespace names that should be excluded from Deployment Safeguards enforcement. This allows certain namespaces to bypass the configured policies.

		// Copyright (c) HashiCorp, Inc.
		// SPDX-License-Identifier: MPL-2.0


		type KubernetesClusterDeploymentSafeguardResource struct{}

		func TestAccKubernetesClusterDeploymentSafeguards_basic(t *testing.T) {

Uh oh!

Conversation

ms-henglu commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

AI Assistance Disclosure

Rollback Plan

Changes to Security Controls

Uh oh!

liuwuliuyun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liuwuliuyun left a comment

Choose a reason for hiding this comment

Uh oh!

ms-zhenhua left a comment

Choose a reason for hiding this comment

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ms-henglu commented Feb 4, 2026 •

edited

Loading