-
Notifications
You must be signed in to change notification settings - Fork 4.5k
bug - fix menu dropdown not opening after delete #22752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug - fix menu dropdown not opening after delete #22752
Conversation
| change: function (index, e = {}) { | ||
| if (e.target.checked && index !== this.checked) { | ||
| set(this, 'checked', parseInt(index)); | ||
| set(this, 'checked', index); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test to cover this behaviour?
.changelog/22752.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:feature | |||
| consul-ui: fixes the issue where when doing deletes of multiple tokens or policies, the three dots on the right hand side stops responding after the first delete. | |||
| ``` No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/hashicorp/consul/blob/main/docs/contributing/add-a-changelog-entry.md
Follow this guide for the changelog.
Here type is bug and code area is ui
|
📣 Hi @rishabh-gupta-hashicorp! a backport is missing for this PR [22752] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description: |
Description
On Consul UI - Token and Policies Pages.
When doing deletes of multiple tokens or policies, the three dots on the right hand side stops responding after the first delete. You can still delete items further down, but not the next item.
Testing & Reproduction steps
##Consul UI Delete Issue - Policies, 2024-03-08_13-13-07.mp4
For top policy "acl-replication", click on ellipse dropdown and select "Delete", "Delete".
The policy "acl-replication" is deleted.
Select the next top policy, "acl-replication-2", click on the ellipse dropdown and notice you can't drop down the selection.
Move to the next policy down, "agent-token", click on the ellipse dropdown and notice that, you can drop down the selection and the "Delete" option is present.
Delete that policy.
Now notice that, of the remaining four policies, the top two policies "acl-replication-2" and "builtin/global-read-only" dropdowns don't work, but the bottom two policies "global-management" and "replication" dropdowns do work.
##Consul UI Delete Issue - Tokens, 2024-03-08_13-20-51.mp4
For the top token "51c611d1", click on ellipse dropdown and select "Delete", "Delete".
The token "51c611d1" is deleted.
Select the next top token, "bd4970ac", click on ellipse dropdown
and notice you can't drop down the selection.
Select the next token down, "b4cf0555", click on the ellipse dropdown and notice that, you can drop down the selection and the "Delete" option is present.
Delete that policy.
Now notice that, of the remaining four tokens, the top two "bd4970ac" and "00000002" dropdowns don't work, but the bottom two tokens "2af2d86a" and "a50817ea" dropdowns do work.
Now, duplicate token "2af2d86a" twice.
Notice that the new tokens at the top, "65e80da1" and "1d3fc582", the dropdowns do work, but don't have the "Delete" option.
Refresh the browser page, and full functionality is returned, as demonstrated by token "65e80da1".
Links
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.