-
Notifications
You must be signed in to change notification settings - Fork 4.5k
UI/bugfix/UI format allow fqdn #22779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/bugfix/UI format allow fqdn #22779
Conversation
|
Thank you @lplinux for the PR. |
Thanks @suresh-hashicorp . I've added the changelog. |
5c75378 to
5067816
Compare
@lplinux CLA sign is pending. I can approve and merge after this. |
I've signed it 3 times already. I hope this last time is the good one. |
suresh-hashicorp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @lplinux
|
📣 Hi @suresh-hashicorp! a backport is missing for this PR [22779] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description: |
Description
We've deployed a new version of consul server (upgraded from 1.21.2 to 1.21.3) and we've lost the ability to see on the UI the list of URLs for certain services that instead of IP Addresses they are FQDN from AWS services.
This might be related to the IP Validation introduced under #22468
Testing & Reproduction steps
Links
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.