Backport of [UI] Remove send Action deprecation into release/1.22.x (#22957)

backport of commit d03f619

Co-authored-by: suresh-hashicorp <[email protected]>

Author: hc-github-team-consul-core

.changelog/22938.txt

@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: removes send action instances as part of https://deprecations.emberjs.com/id/ember-component-send-action/
+```

ui/packages/consul-lock-sessions/app/components/consul/lock-session/form/index.hbs

@@ -86,7 +86,7 @@
               @text='Invalidate Session'
               @color='critical'
               data-test-delete
-              {{on 'click' (fn confirm (fn writer.delete @item))}}
+              {{on 'click' (fn confirm )}}
             />
           </BlockSlot>
           <BlockSlot @name="dialog" as |execute cancel message|>
@@ -98,7 +98,7 @@
                 @text='Confirm Invalidation'
                 @color='critical'
                 data-test-delete
-                {{on 'click' (fn execute)}}
+                {{on 'click' (queue execute (fn writer.delete @item))}}
               />
               <Hds::Button
                 @text='Cancel'

ui/packages/consul-lock-sessions/app/components/consul/lock-session/list/index.hbs

@@ -90,7 +90,7 @@ as |item index|>
           @text='Invalidate'
           @color='critical'
           data-test-delete
-          {{on 'click' (fn confirm (fn @ondelete item))}}
+          {{on 'click' confirm}}
         />
       </BlockSlot>
       <BlockSlot @name="dialog" as |execute cancel message|>
@@ -102,7 +102,7 @@ as |item index|>
             @text='Confirm Invalidate'
             @color='critical'
             data-test-delete
-            {{on 'click' (fn execute)}}
+            {{on 'click' (queue execute (fn @ondelete item))}}
           />
           <Hds::Button
             @text='Cancel'

ui/packages/consul-nspaces/app/components/consul/nspace/form/index.hbs

@@ -145,13 +145,13 @@
                       data-test-delete
                       @color='critical'
                       @text='Delete'
-                      {{on "click" (fn confirm (fn writer.delete item))}}
+                      {{on "click" (fn confirm )}}
                     />
                   </BlockSlot>
                   <BlockSlot @name="dialog" as |execute cancel message|>
                     <DeleteConfirmation
                       @message={{message}}
-                      @execute={{execute}}
+                      @execute={{queue execute (fn writer.delete item)}}
                       @cancel={{cancel}}
                     />
                   </BlockSlot>

ui/packages/consul-partitions/app/components/consul/partition/form/index.hbs

@@ -118,13 +118,13 @@ as |State Guard ChartAction dispatch state|>
             @text='Delete'
             data-test-delete
             @color='critical'
-            {{on 'click' (fn confirm (fn writer.delete item))}}
+            {{on 'click' confirm}}
           />
         </BlockSlot>
         <BlockSlot @name="dialog" as |execute cancel message|>
           <DeleteConfirmation
             @message={{message}}
-            @execute={{execute}}
+            @execute={{queue execute (fn writer.delete item)}}
             @cancel={{cancel}}
           />
         </BlockSlot>

ui/packages/consul-ui/app/components/child-selector/index.hbs

@@ -50,7 +50,7 @@
   </label>
 {{/if}}
 {{#if (gt items.length 0)}}
-  <YieldSlot @name="set">{{yield}}</YieldSlot>
+  <YieldSlot @name="set" @params={{block-params (action "remove")}}>{{yield}}</YieldSlot>
 {{else}}
 
 {{/if}}

ui/packages/consul-ui/app/components/confirmation-dialog/index.js

@@ -3,30 +3,30 @@
  * SPDX-License-Identifier: BUSL-1.1
  */
 
-/*eslint ember/closure-actions: "warn"*/
 import Component from '@ember/component';
+import { action } from '@ember/object';
+import { tracked } from '@glimmer/tracking';
 
 import Slotted from 'block-slots';
-import { set } from '@ember/object';
 
-export default Component.extend(Slotted, {
-  tagName: '',
-  message: 'Are you sure?',
-  confirming: false,
-  permanent: false,
-  actions: {
-    cancel: function () {
-      set(this, 'confirming', false);
-    },
-    execute: function () {
-      set(this, 'confirming', false);
-      this.sendAction(...['actionName', ...this['arguments']]);
-    },
-    confirm: function () {
-      const [action, ...args] = arguments;
-      set(this, 'actionName', action);
-      set(this, 'arguments', args);
-      set(this, 'confirming', true);
-    },
-  },
-});
+export default class ConfirmationDialogComponent extends Component.extend(Slotted) {
+  tagName = '';
+  message = 'Are you sure?';
+  @tracked confirming = false;
+  permanent = false;
+
+  @action
+  cancel() {
+    this.confirming = false;
+  }
+
+  @action
+  execute() {
+    this.confirming = false;
+  }
+
+  @action
+  confirm() {
+    this.confirming = true;
+  }
+}

ui/packages/consul-ui/app/components/consul/intention/form/index.hbs

@@ -178,14 +178,14 @@ as |item readonly|}}
                 @text='Delete'
                 @color='critical'
                 disabled={{api.disabled}}
-                {{on 'click' (fn confirm api.delete)}}
+                {{on 'click' (fn confirm)}}
                 data-test-delete
               />
             </BlockSlot>
             <BlockSlot @name="dialog" as |execute cancel message|>
               <DeleteConfirmation
                 @message={{message}}
-                @execute={{execute}}
+                @execute={{queue execute api.delete}}
                 @cancel={{cancel}}
               />
             </BlockSlot>

ui/packages/consul-ui/app/components/consul/intention/list/table/index.hbs

@@ -95,7 +95,7 @@
       <BlockSlot @name='trigger'>
         More
       </BlockSlot>
-      <BlockSlot @name='menu' as |confirm send keypressClick change|>
+      <BlockSlot @name='menu' as |confirm keypressClick change|>
         {{#if (can 'write intention' item=item)}}
           <components.MenuItem href={{href-to (or routeName 'dc.intentions.edit') item.ID}}>
             <BlockSlot @name="label">

ui/packages/consul-ui/app/components/consul/kv/form/index.hbs

@@ -127,13 +127,13 @@
                     @color='critical'
                     data-test-delete
                     disabled={{api.disabled}}
-                    {{on 'click' (action confirm api.delete)}}
+                    {{on 'click' (action confirm)}}
                   />
                 </BlockSlot>
                 <BlockSlot @name='dialog' as |execute cancel message|>
                   <DeleteConfirmation
                     @message={{message}}
-                    @execute={{execute}}
+                    @execute={{queue execute api.delete}}
                     @cancel={{cancel}}
                   />
                 </BlockSlot>