namespace list shows up after tab switching

Author: rishabh-gupta-hashicorp

ui/packages/consul-nspaces/app/templates/dc/nspaces/index.hbs

@@ -14,7 +14,6 @@ as |route|>
         nspace=route.params.nspace
         dc=route.params.dc
       )}}
-      @useCachedOnEmpty={{true}}
     as |loader|>
 
     <BlockSlot @name="error">

ui/packages/consul-ui/app/components/data-loader/index.js

@@ -29,23 +29,8 @@ export default Component.extend(Slotted, {
     isLoaded: function () {
       return typeof this.items !== 'undefined' || typeof this.src === 'undefined';
     },
-    // caching data for namesapce page only currently to avoid showing a Welcome screen when we switch tabs
-    // and come back to this page.
-    // For other pages, it will behave as before without a need of explicit caching logic used here.
     change: function (data) {
-      if (
-        this.useCachedOnEmpty && // Only apply for namespace page
-        ((Array.isArray(data) && data.length === 0) || (!Array.isArray(data) && !data))
-      ) {
-        if (this._lastKnownData) {
-          set(this, 'data', this.onchange(this._lastKnownData));
-        } else {
-          set(this, 'data', this.onchange(data));
-        }
-      } else {
-        set(this, 'data', this.onchange(data));
-        this._lastKnownData = data;
-      }
+      set(this, 'data', this.onchange(data));
     },
   },
 });

ui/packages/consul-ui/app/services/repository/nspace.js

@@ -57,7 +57,7 @@ export default class NspaceService extends RepositoryService {
     if (!this.permissions.can('use nspaces')) {
       return [];
     }
-    return super.findAll(...arguments).catch(() => []);
+    return super.findAll(...arguments);
   }
 
   @dataSource('/:partition/:ns/:dc/namespace/:id')