-
Notifications
You must be signed in to change notification settings - Fork 206
IceCreamDebugger now ignores exceptions in formatting #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@gruns Can you merge this in? I just had another run interrupted because I was editing the source code of my program (while the code was running) and |
|
bumping this |
|
@NightMachinery thank you for the bump! always appreciated 🙏
so! what behavior exactly causes these exceptions to be thrown? and then lets figure out the best way to catch those exceptions. because, ideally there's a way to avoid throwing those exceptions to begin with that said, we also do want to prevent icecream from ever crashing your program. icecream should never do that. so perhaps a blanket, catch all cc @Jakeroid for your thoughts here 🙌 |
|
I completely agree that icecream should not crash any code. @NightMachinery Could you provide a code example where icecream does the crash/exceptions/etc? |
|
I don't have a reproducible example, but this has happened several times to me so now I always install my own fork with this patch. |
|
Does your fork have the same patched code as this PR? |
|
@Jakeroid Yes. |
When using
icecreamwithmultiprocessing, I had this exception. So I simply added a try-catch-print to Icecream to avoid breaking the program when something unexpected happens, as the results of the print are for debugging purposes and don't change program behavior anyway.This exception interrupted a longrunning computation, so I believe my PR is quite useful.