Merge pull request #2559 from gusumuzhe/fix/load-balancer-infinite-loop

murgatroid99 · web-flow · commit 8d532f95db0f · 2023-08-29T10:06:28.000-07:00
Fix pick-first-load-balancer pick subchannel lost state listener
diff --git a/packages/grpc-js/src/load-balancer-pick-first.ts b/packages/grpc-js/src/load-balancer-pick-first.ts
@@ -315,7 +315,7 @@ export class PickFirstLoadBalancer implements LoadBalancer {
   }
 
   private pickSubchannel(subchannel: SubchannelInterface) {
-    if (subchannel === this.currentPick) {
+    if (this.currentPick && subchannel.realSubchannelEquals(this.currentPick)) {
       return;
     }
     trace('Pick subchannel with address ' + subchannel.getAddress());

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ export class PickFirstLoadBalancer implements LoadBalancer {`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`private pickSubchannel(subchannel: SubchannelInterface) {`
`318`		`- if (subchannel === this.currentPick) {`
	`318`	`+ if (this.currentPick && subchannel.realSubchannelEquals(this.currentPick)) {`
`319`	`319`	`return;`
`320`	`320`	`}`
`321`	`321`	`trace('Pick subchannel with address ' + subchannel.getAddress());`