diff --git a/xds/internal/clients/xdsclient/xdsclient.go b/xds/internal/clients/xdsclient/xdsclient.go index e8138198f6ec..93d26217480d 100644 --- a/xds/internal/clients/xdsclient/xdsclient.go +++ b/xds/internal/clients/xdsclient/xdsclient.go @@ -101,8 +101,6 @@ type XDSClient struct { // New returns a new xDS Client configured with the provided config. func New(config Config) (*XDSClient, error) { switch { - case config.Node.ID == "": - return nil, errors.New("xdsclient: node ID is empty") case config.ResourceTypes == nil: return nil, errors.New("xdsclient: resource types map is nil") case config.TransportBuilder == nil: diff --git a/xds/internal/clients/xdsclient/xdsclient_test.go b/xds/internal/clients/xdsclient/xdsclient_test.go index 69b640069d23..073362d02a4d 100644 --- a/xds/internal/clients/xdsclient/xdsclient_test.go +++ b/xds/internal/clients/xdsclient/xdsclient_test.go @@ -36,11 +36,6 @@ func (s) TestXDSClient_New(t *testing.T) { config Config wantErr string }{ - { - name: "empty node ID", - config: Config{}, - wantErr: "node ID is empty", - }, { name: "nil resource types", config: Config{ @@ -75,6 +70,16 @@ func (s) TestXDSClient_New(t *testing.T) { }, wantErr: "", }, + { + name: "success with servers and empty nodeID", + config: Config{ + Node: clients.Node{ID: ""}, + ResourceTypes: map[string]ResourceType{xdsresource.V3ListenerURL: listenerType}, + TransportBuilder: grpctransport.NewBuilder(configs), + Servers: []ServerConfig{{ServerIdentifier: clients.ServerIdentifier{ServerURI: "dummy-server"}}}, + }, + wantErr: "", + }, { name: "success with authorities", config: Config{