Skip to content

transport: reduce memory usage for small reads in server handler #7972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lqs wants to merge 1 commit into from
Closed

transport: reduce memory usage for small reads in server handler #7972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/transport/handler_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,16 @@ func (ht *serverHandlerTransport) HandleStreams(ctx context.Context, startStream
for {
buf := ht.bufferPool.Get(http2MaxFrameLen)
n, err := req.Body.Read(*buf)
if n > 0 {
if n > http2MaxFrameLen/4 {
// size is big enough, just use the buffer
*buf = (*buf)[:n]
s.buf.put(recvMsg{buffer: mem.NewBuffer(buf, ht.bufferPool)})
} else if n > 0 {
// move to a smaller buffer and put back the original buffer
newBuf := ht.bufferPool.Get(n)
copy(*newBuf, (*buf)[:n])
ht.bufferPool.Put(buf)
s.buf.put(recvMsg{buffer: mem.NewBuffer(newBuf, ht.bufferPool)})
} else {
ht.bufferPool.Put(buf)
}
Expand Down
Loading