pickfirst: receive state updates via callback instead of UpdateSubConnState #6495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Aug 1, 2023
| // UpdateSubConnState is unused as a StateListener is always registered when | ||
| // creating SubConns. | ||
| func (b *pickfirstBalancer) UpdateSubConnState(subConn balancer.SubConn, state balancer.SubConnState) { | ||
| } |
Contributor
There was a problem hiding this comment.
Should we throw an error log here, just to ensure that it is caught by our tests if by any chance this ends up happening?
easwars
approved these changes
Aug 1, 2023
| // UpdateSubConnState is unused as a StateListener is always registered when | ||
| // creating SubConns. | ||
| func (b *pickfirstBalancer) UpdateSubConnState(subConn balancer.SubConn, state balancer.SubConnState) { | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6472
This is a minimal change to migrate
pick_firstto theStateNotifier. Since PF is slated to become a lot more complex, I didn't want to do any significant refactoring here.RELEASE NOTES: none