resolver: keep full unparsed target string if scheme in parsed target is not registered #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Mar 26, 2018
dfawley
approved these changes
Mar 27, 2018
|
Should this be backported to a 1.10.1? |
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Mar 28, 2018
… is not registered (grpc#1943)
Contributor
Author
|
@menghanl Thanks for the backport! |
Contributor
|
@menghanl Thanks for addressing this one! |
Contributor
|
BTW, I just confirmed the fix against 1.7 servers with 1.10.1 clients and everything looks good. Tests are ran as part of containerd/containerd#2186 and we are looking good. |
Contributor
Author
|
@stevvooe That sounds great! Thanks for the update! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For target
unix:///foo:Before: it is parsed as
{scheme: "unix", authority: "", endpoint: "foo"}, and the fallback resolver (passthrough) will get"foo"as the endpoint.After:
{scheme: "", authority: "", endpoint: "unix:///foo"}, thepassthroughresolver will get"unix:///foo"as the endpoint.fixes #1899
related to #1889