advancedtls: use realistic ciphersuite in test (#7273)

rolandshoemaker · web-flow · commit a4593c58818a · 2024-05-29T10:56:01.000-04:00
Instead of 3DES, something which should basically never be used in
production. Go is removing default support for 3DES is Go 1.24,
requiring new modules to opt into support for this cipher.
diff --git a/security/advancedtls/advancedtls_test.go b/security/advancedtls/advancedtls_test.go
@@ -1107,7 +1107,7 @@ func (s) TestGetCertificatesSNI(t *testing.T) {
 			}
 			pointFormatUncompressed := uint8(0)
 			clientHello := &tls.ClientHelloInfo{
-				CipherSuites:      []uint16{tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA},
+				CipherSuites:      []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA},
 				ServerName:        test.serverName,
 				SupportedCurves:   []tls.CurveID{tls.CurveP256},
 				SupportedPoints:   []uint8{pointFormatUncompressed},

Original file line number	Diff line number	Diff line change
`@@ -1107,7 +1107,7 @@ func (s) TestGetCertificatesSNI(t *testing.T) {`
`1107`	`1107`	`}`
`1108`	`1108`	`pointFormatUncompressed := uint8(0)`
`1109`	`1109`	`clientHello := &tls.ClientHelloInfo{`
`1110`		`- CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA},`
	`1110`	`+ CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA},`
`1111`	`1111`	`ServerName: test.serverName,`
`1112`	`1112`	`SupportedCurves: []tls.CurveID{tls.CurveP256},`
`1113`	`1113`	`SupportedPoints: []uint8{pointFormatUncompressed},`