Skip to content

Commit 9f0e2e4

Browse files
committed
review comments
1 parent 0109963 commit 9f0e2e4

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

dialoptions.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -709,9 +709,7 @@ func WithIdleTimeout(d time.Duration) DialOption {
709709
// Deprecated: use experimental.WithRecvBufferPool instead. Will be deleted in
710710
// v1.60.0 or later.
711711
func WithRecvBufferPool(bufferPool SharedBufferPool) DialOption {
712-
return newFuncDialOption(func(o *dialOptions) {
713-
o.recvBufferPool = bufferPool
714-
})
712+
return withRecvBufferPool(bufferPool)
715713
}
716714

717715
func withRecvBufferPool(bufferPool SharedBufferPool) DialOption {

experimental/experimental.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*
1717
*/
1818

19-
// Package experimental is a placeholder for experimental features that might
19+
// Package experimental is a collection of experimental features that might
2020
// have some rough edges to them. Housing experimental features in this package
2121
// results in a user accessing these APIs as `experimental.Foo`, thereby making
2222
// it explicit that the feature is experimental and using them in production

server.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -584,9 +584,7 @@ func NumStreamWorkers(numServerWorkers uint32) ServerOption {
584584
// Deprecated: use experimental.WithRecvBufferPool instead. Will be deleted in
585585
// v1.60.0 or later.
586586
func RecvBufferPool(bufferPool SharedBufferPool) ServerOption {
587-
return newFuncServerOption(func(o *serverOptions) {
588-
o.recvBufferPool = bufferPool
589-
})
587+
return recvBufferPool(bufferPool)
590588
}
591589

592590
func recvBufferPool(bufferPool SharedBufferPool) ServerOption {

0 commit comments

Comments
 (0)